Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1136)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

Issue 2102453003: [DevTools] Move collectionEntries to internalProperties in protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
index c8949430c90d506a61a85d19f41bc1428a597c29..586a8ba9a8d284be465590b4d917545ae50805b7 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp
@@ -25,7 +25,6 @@ using blink::protocol::Array;
using blink::protocol::Maybe;
using blink::protocol::Debugger::BreakpointId;
using blink::protocol::Debugger::CallFrame;
-using blink::protocol::Debugger::CollectionEntry;
using blink::protocol::Runtime::ExceptionDetails;
using blink::protocol::Debugger::FunctionDetails;
using blink::protocol::Debugger::GeneratorObjectDetails;
@@ -714,40 +713,6 @@ void V8DebuggerAgentImpl::getGeneratorObjectDetails(ErrorString* errorString, co
*outDetails = std::move(protocolDetails);
}
-void V8DebuggerAgentImpl::getCollectionEntries(ErrorString* errorString, const String16& objectId, std::unique_ptr<protocol::Array<CollectionEntry>>* outEntries)
-{
- if (!checkEnabled(errorString))
- return;
- InjectedScript::ObjectScope scope(errorString, m_debugger, m_session->contextGroupId(), objectId);
- if (!scope.initialize())
- return;
- if (!scope.object()->IsObject()) {
- *errorString = "Object with given id is not a collection";
- return;
- }
- v8::Local<v8::Object> object = scope.object().As<v8::Object>();
-
- v8::Local<v8::Value> entriesValue = m_debugger->collectionEntries(object);
- if (hasInternalError(errorString, entriesValue.IsEmpty()))
- return;
- if (entriesValue->IsUndefined()) {
- *errorString = "Object with given id is not a collection";
- return;
- }
- if (hasInternalError(errorString, !entriesValue->IsArray()))
- return;
- v8::Local<v8::Array> entriesArray = entriesValue.As<v8::Array>();
- if (!scope.injectedScript()->wrapPropertyInArray(errorString, entriesArray, toV8StringInternalized(m_isolate, "key"), scope.objectGroupName()))
- return;
- if (!scope.injectedScript()->wrapPropertyInArray(errorString, entriesArray, toV8StringInternalized(m_isolate, "value"), scope.objectGroupName()))
- return;
- protocol::ErrorSupport errors;
- std::unique_ptr<protocol::Array<CollectionEntry>> entries = protocol::Array<CollectionEntry>::parse(toProtocolValue(scope.context(), entriesArray).get(), &errors);
- if (hasInternalError(errorString, !entries))
- return;
- *outEntries = std::move(entries);
-}
-
void V8DebuggerAgentImpl::schedulePauseOnNextStatement(const String16& breakReason, std::unique_ptr<protocol::DictionaryValue> data)
{
if (!enabled() || m_scheduledDebuggerStep == StepInto || m_javaScriptPauseScheduled || debugger().isPaused() || !debugger().breakpointsActivated())

Powered by Google App Engine
This is Rietveld 408576698