Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2102263003: Split mojo/public/cpp/system/tests/core_unittest.cc, part 1. (Closed)

Created:
4 years, 5 months ago by viettrungluu
Modified:
4 years, 5 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Split mojo/public/cpp/system/tests/core_unittest.cc, part 1. R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0e34ee926b140853b6d8ae4f317affc7caffe672

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -207 lines) Patch
M mojo/public/cpp/system/tests/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/cpp/system/tests/core_unittest.cc View 5 chunks +2 lines, -207 lines 0 comments Download
A mojo/public/cpp/system/tests/data_pipe_unittest.cc View 1 chunk +121 lines, -0 lines 0 comments Download
A mojo/public/cpp/system/tests/handle_unittest.cc View 1 chunk +175 lines, -0 lines 0 comments Download
A mojo/public/cpp/system/tests/time_unittest.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 5 months ago (2016-06-28 23:12:09 UTC) #1
azani
lgtm
4 years, 5 months ago (2016-06-29 00:01:54 UTC) #2
viettrungluu
4 years, 5 months ago (2016-06-29 00:14:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0e34ee926b140853b6d8ae4f317affc7caffe672 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698