[heap] Iterate handles with special left-trim visitor

[heap] Iterate handles with special left-trim visitor

BUG=chromium:620553
LOG=N
R=hpayer@chromium.org

Committed: https://crrev.com/a7159577b7d092ef6283c51f8bb2c456b0e23a38
Cr-Commit-Position: refs/heads/master@{#37366}

[Michael Lippautz, 2016-06-28 20:11:36]

Description was changed from

==========
[heap] Iterate handles with special left-trim visitor

BUG=
==========

to

==========
[heap] Iterate handles with special left-trim visitor

BUG=
R=hpayer@chromium.org
==========

[Michael Lippautz, 2016-06-28 20:11:36]

mlippautz@chromium.org changed reviewers:
+ hpayer@chromium.org

[Hannes Payer (out of office), 2016-06-28 20:19:11]

https://codereview.chromium.org/2102243002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2102243002/diff/1/src/heap/heap.cc#newcode4777
src/heap/heap.cc:4777: if (current->IsFiller()) {
I think we have to check for forwarding pointers here.

[Michael Lippautz, 2016-06-29 06:03:14]

Description was changed from

==========
[heap] Iterate handles with special left-trim visitor

BUG=
R=hpayer@chromium.org
==========

to

==========
[heap] Iterate handles with special left-trim visitor

BUG=chromium:620553
LOG=N
R=hpayer@chromium.org
==========

[Michael Lippautz, 2016-06-29 06:03:58]

https://codereview.chromium.org/2102243002/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2102243002/diff/1/src/heap/heap.cc#newcode4777
src/heap/heap.cc:4777: if (current->IsFiller()) {
On 2016/06/28 20:19:11, Hannes Payer (slow) wrote:
> I think we have to check for forwarding pointers here.

Done.(+ HeapObject check)

[Michael Lippautz, 2016-06-29 06:04:03]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 06:04:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-06-29 06:30:39]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-06-29 06:30:40]

lgtm

[commit-bot: I haz the power, 2016-06-29 06:33:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 06:33:52]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2016-06-29 07:47:44]

lgtm

[Michael Lippautz, 2016-06-29 07:53:38]

The CQ bit was checked by mlippautz@chromium.org

[commit-bot: I haz the power, 2016-06-29 07:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 08:16:14]

Description was changed from

==========
[heap] Iterate handles with special left-trim visitor

BUG=chromium:620553
LOG=N
R=hpayer@chromium.org
==========

to

==========
[heap] Iterate handles with special left-trim visitor

BUG=chromium:620553
LOG=N
R=hpayer@chromium.org
==========

[commit-bot: I haz the power, 2016-06-29 08:16:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 08:18:33]

Description was changed from

==========
[heap] Iterate handles with special left-trim visitor

BUG=chromium:620553
LOG=N
R=hpayer@chromium.org
==========

to

==========
[heap] Iterate handles with special left-trim visitor

BUG=chromium:620553
LOG=N
R=hpayer@chromium.org

Committed: https://crrev.com/a7159577b7d092ef6283c51f8bb2c456b0e23a38
Cr-Commit-Position: refs/heads/master@{#37366}
==========

[commit-bot: I haz the power, 2016-06-29 08:18:34]

Patchset 2 (id:??) landed as
https://crrev.com/a7159577b7d092ef6283c51f8bb2c456b0e23a38
Cr-Commit-Position: refs/heads/master@{#37366}