Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2102183003: 🎠 Suppress lint warnings for policy resources (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress lint warnings for policy resources They are unused because they are used by magic. They are missing translations to save file size (see http://crbug.com/450548) BUG=621771 Committed: https://crrev.com/d7e9b95f80ab96881ca7ecb5f6621536aad2743a Cr-Commit-Position: refs/heads/master@{#403401}

Patch Set 1 #

Patch Set 2 : Suppress MissingTranslation lint warnings for policy resources #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M build/android/lint/suppressions.xml View 1 2 chunks +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
agrieve
On 2016/07/01 03:02:27, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:twellington@chromium.org
4 years, 5 months ago (2016-07-01 03:02:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102183003/20001
4 years, 5 months ago (2016-07-01 03:03:14 UTC) #5
Theresa
lgtm
4 years, 5 months ago (2016-07-01 03:17:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102183003/20001
4 years, 5 months ago (2016-07-01 03:24:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 03:41:15 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-01 03:41:17 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 03:45:18 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7e9b95f80ab96881ca7ecb5f6621536aad2743a
Cr-Commit-Position: refs/heads/master@{#403401}

Powered by Google App Engine
This is Rietveld 408576698