Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 2113233002: 🎓 Provide AndroidManifest.xml to chrome_java to fix UnusedResources warnings (Closed)

Created:
4 years, 5 months ago by agrieve
Modified:
4 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide AndroidManifest.xml to chrome_java to fix UnusedResources warnings BUG=621770 Committed: https://crrev.com/3528705e8b93d3a070f1d31e2dd355db1c33f52c Cr-Commit-Position: refs/heads/master@{#403818}

Patch Set 1 #

Patch Set 2 : remove now-useless suppressions #

Patch Set 3 : Provide AndroidManifest.xml to chrome_java to fix UnusedResources warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -29 lines) Patch
M build/android/lint/suppressions.xml View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/BUILD.gn View 4 chunks +27 lines, -22 lines 0 comments Download
M content/shell/android/BUILD.gn View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
agrieve
4 years, 5 months ago (2016-07-01 02:40:19 UTC) #2
agrieve
On 2016/07/01 02:40:19, agrieve wrote: lgtm (just wanting to test if I'm an OWNER for ...
4 years, 5 months ago (2016-07-01 02:46:40 UTC) #3
agrieve
On 2016/07/01 02:46:40, agrieve wrote: > On 2016/07/01 02:40:19, agrieve wrote: > > lgtm (just ...
4 years, 5 months ago (2016-07-01 02:47:10 UTC) #4
Yaron
lgtm
4 years, 5 months ago (2016-07-05 15:27:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113233002/20001
4 years, 5 months ago (2016-07-05 16:08:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/31136) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-05 16:10:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2113233002/40001
4 years, 5 months ago (2016-07-05 18:33:57 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-05 19:48:35 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 19:48:39 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 19:50:24 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3528705e8b93d3a070f1d31e2dd355db1c33f52c
Cr-Commit-Position: refs/heads/master@{#403818}

Powered by Google App Engine
This is Rietveld 408576698