[ic] Use UnseededNumberDictionary as a storage for names in TypeFeedbackMetadata.

[ic] Use UnseededNumberDictionary as a storage for names in TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312, chromium:623516
Committed: https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0
Cr-Commit-Position: refs/heads/master@{#37336}

[Igor Sheludko, 2016-06-28 14:29:02]

Description was changed from

==========
[ic] Use UnseededNumberDictionary as a storage of names in TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

BUG=chromium:576312
==========

to

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-06-28 15:04:30]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-06-28 15:04:36]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 15:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 15:06:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 15:06:31]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/8117)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/8097)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/18233)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Igor Sheludko, 2016-06-28 15:08:58]

Description was changed from

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

BUG=chromium:576312
==========

to

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312
==========

[Igor Sheludko, 2016-06-28 15:25:12]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-06-28 15:25:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-28 15:25:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-06-28 15:27:51]

Description was changed from

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312
==========

to

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312, chromium:623516
==========

[ulan, 2016-06-28 15:32:46]

ulan@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2016-06-28 15:32:47]

heap lgtm

[commit-bot: I haz the power, 2016-06-28 15:51:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 15:51:40]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-06-28 15:53:29]

ishell@chromium.org changed reviewers:
+ cbruni@chromium.org

[Igor Sheludko, 2016-06-28 15:53:30]

PTAL

[Camillo Bruni, 2016-06-28 16:04:25]

lgtm, maybe we should rename the UnseededNumberDictionary at some point...

[Igor Sheludko, 2016-06-28 16:12:58]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-06-28 16:13:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 16:15:27]

Description was changed from

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312, chromium:623516
==========

to

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312, chromium:623516
==========

[commit-bot: I haz the power, 2016-06-28 16:15:28]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-06-28 16:16:24]

Description was changed from

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312, chromium:623516
==========

to

==========
[ic] Use UnseededNumberDictionary as a storage for names in
TypeFeedbackMetadata.

The serializer does not support serialization of HashTables in general because
after deserialization it might be necessary to rehash the table.
However the UnseededNumberDictionary does not require rehashing and this CL
allows
them to be serialized.

This CL also changes the shape of UnseededNumberDictionary: the details field is
no longer part of the entry since no one needs it.

BUG=chromium:576312, chromium:623516

Committed: https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0
Cr-Commit-Position: refs/heads/master@{#37336}
==========

[commit-bot: I haz the power, 2016-06-28 16:16:26]

Patchset 1 (id:??) landed as
https://crrev.com/70318619905dd1a10ac0f063da19cebf6d385ba0
Cr-Commit-Position: refs/heads/master@{#37336}

[Yang, 2016-06-28 17:10:31]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2016-06-28 17:10:32]

https://codereview.chromium.org/2102073002/diff/40001/src/heap/heap.h
File src/heap/heap.h (right):

https://codereview.chromium.org/2102073002/diff/40001/src/heap/heap.h#newcode49
src/heap/heap.h:49: V(Map, unseeded_number_dictionary_map,
UnseededNumberDictionaryMap)          \
Please do NOT put the map randomly into the first 32 entries of the root list.
This list is carefully chosen. See comment above.