Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: src/objects-inl.h

Issue 2102073002: [ic] Use UnseededNumberDictionary as a storage for names in TypeFeedbackMetadata. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index 5d59cd3e19ef74852fe1fd0f2a3be3416fd8a4a3..b30e9626c5e79a52e59c0a2484071b805284de2c 100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -850,9 +850,8 @@ bool Object::IsSeededNumberDictionary() const {
return IsDictionary();
}
-
-bool Object::IsUnseededNumberDictionary() const {
- return IsDictionary();
+bool HeapObject::IsUnseededNumberDictionary() const {
+ return map() == GetHeap()->unseeded_number_dictionary_map();
}
bool HeapObject::IsStringTable() const { return IsHashTable(); }
@@ -3063,6 +3062,10 @@ void HashTableBase::SetNumberOfDeletedElements(int nod) {
set(kNumberOfDeletedElementsIndex, Smi::FromInt(nod));
}
+template <typename Key>
+Map* BaseShape<Key>::GetMap(Isolate* isolate) {
+ return isolate->heap()->hash_table_map();
+}
template <typename Derived, typename Shape, typename Key>
int HashTable<Derived, Shape, Key>::FindEntry(Key key) {
@@ -7473,14 +7476,16 @@ void BaseDictionaryShape<Key>::SetEntry(Dictionary* dict, int entry,
Handle<Object> key,
Handle<Object> value,
PropertyDetails details) {
- STATIC_ASSERT(Dictionary::kEntrySize == 3);
+ STATIC_ASSERT(Dictionary::kEntrySize == 2 || Dictionary::kEntrySize == 3);
DCHECK(!key->IsName() || details.dictionary_index() > 0);
int index = dict->EntryToIndex(entry);
DisallowHeapAllocation no_gc;
WriteBarrierMode mode = dict->GetWriteBarrierMode(no_gc);
dict->set(index + Dictionary::kEntryKeyIndex, *key, mode);
dict->set(index + Dictionary::kEntryValueIndex, *value, mode);
- dict->set(index + Dictionary::kEntryDetailsIndex, details.AsSmi());
+ if (Dictionary::kEntrySize == 3) {
+ dict->set(index + Dictionary::kEntryDetailsIndex, details.AsSmi());
+ }
}
@@ -7517,6 +7522,9 @@ uint32_t UnseededNumberDictionaryShape::HashForObject(uint32_t key,
return ComputeIntegerHash(static_cast<uint32_t>(other->Number()), 0);
}
+Map* UnseededNumberDictionaryShape::GetMap(Isolate* isolate) {
+ return *isolate->factory()->unseeded_number_dictionary_map();
+}
uint32_t SeededNumberDictionaryShape::SeededHash(uint32_t key, uint32_t seed) {
return ComputeIntegerHash(key, seed);
« src/heap/heap.h ('K') | « src/objects.cc ('k') | src/type-feedback-vector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698