Add ContentSuggestionsService

components/ntp_snippets/content_suggestion.h

Index: components/ntp_snippets/content_suggestion.h
diff --git a/components/ntp_snippets/content_suggestion.h b/components/ntp_snippets/content_suggestion.h
index 60ab27285d39153f84cbc3440fa5346646f6a7d5..a0990b357f9a927111b3fb9e3a142ff29787a71d 100644
--- a/components/ntp_snippets/content_suggestion.h
+++ b/components/ntp_snippets/content_suggestion.h
@@ -24,20 +24,18 @@ namespace ntp_snippets {
 class ContentSuggestion {
  public:
   ContentSuggestion(const std::string& id,

[Marc Treib, 2016/06/30 10:36:53]

Rename this to "provider_id" or something like that, to make clear that it's not
the actual ID of the ContentSuggestion? And/or add a comment explaining what's
going on.

[Philipp Keck, 2016/06/30 17:14:07]

Should avoid "provider_id" because it would be an ID that identifies the
provider itself. I call it "original_id" here because that's also the term used
elsewhere.
Added comments here and in the ContentSuggestionsProvider interface.

[Marc Treib, 2016/07/01 09:15:32]

Acknowledged.

-                    const ContentSuggestionsProviderType provider,
+                    const ContentSuggestionsProviderType provider_type,
                     const ContentSuggestionCategory category,
                     const GURL& url);
+  ContentSuggestion(ContentSuggestion&&);
+  ContentSuggestion& operator=(ContentSuggestion&&);
 
   ~ContentSuggestion();
 
   // An ID for identifying the suggestion. The ID is unique among all
-  // suggestions from the same provider, so to determine a globally unique
-  // identifier, combine this ID with the provider type.
+  // suggestions of all providers.
   const std::string& id() const { return id_; }
 
-  // The provider that created this suggestion.
-  ContentSuggestionsProviderType provider() const { return provider_; }
-
   // The category that this suggestion belongs to.
   ContentSuggestionCategory category() const { return category_; }
 
@@ -82,7 +80,6 @@ class ContentSuggestion {
 
  private:
   std::string id_;
-  ContentSuggestionsProviderType provider_;
   ContentSuggestionCategory category_;
   GURL url_;
   GURL amp_url_;