Add ContentSuggestionsService

components/ntp_snippets/content_suggestion.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTION_H_
 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTION_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "components/ntp_snippets/content_suggestion_category.h"
 #include "components/ntp_snippets/content_suggestions_provider_type.h"
 #include "url/gurl.h"
 
 namespace ntp_snippets {
 
 // A content suggestion for the new tab page, which can be an article or an
 // offline page, for example.
 // NOTE: This class is not yet in use, please use NTPSnippet for now
 // (see ntp_snippet.h).
 class ContentSuggestion {
  public:
   ContentSuggestion(const std::string& id,

[Marc Treib, 2016/06/30 10:36:53]

Rename this to "provider_id" or something like that, to make clear that it's not
the actual ID of the ContentSuggestion? And/or add a comment explaining what's
going on.

[Philipp Keck, 2016/06/30 17:14:07]

Should avoid "provider_id" because it would be an ID that identifies the
provider itself. I call it "original_id" here because that's also the term used
elsewhere.
Added comments here and in the ContentSuggestionsProvider interface.

[Marc Treib, 2016/07/01 09:15:32]

Acknowledged.

-                    const ContentSuggestionsProviderType provider,
+                    const ContentSuggestionsProviderType provider_type,
                     const ContentSuggestionCategory category,
                     const GURL& url);
+  ContentSuggestion(ContentSuggestion&&);
+  ContentSuggestion& operator=(ContentSuggestion&&);
 
   ~ContentSuggestion();
 
   // An ID for identifying the suggestion. The ID is unique among all
-  // suggestions from the same provider, so to determine a globally unique
-  // identifier, combine this ID with the provider type.
+  // suggestions of all providers.
   const std::string& id() const { return id_; }
 
-  // The provider that created this suggestion.
-  ContentSuggestionsProviderType provider() const { return provider_; }
-
   // The category that this suggestion belongs to.
   ContentSuggestionCategory category() const { return category_; }
 
   // The normal content URL where the content referenced by the suggestion can
   // be accessed.
   const GURL& url() const { return url_; }
 
   // If available, this contains an URL to an AMP version of the same content.
   // Otherwise, this is an empty GURL().
   const GURL& amp_url() const { return amp_url_; }
@@ skipping 24 matching lines @@
   // TODO(pke) Remove the score from the ContentSuggestion class. The UI only
   // uses it to track user clicks (histogram data). Instead, the providers
   // should be informed about clicks and do appropriate logging themselves.
   // IMPORTANT: The score may simply be 0 for suggestions from providers which
   // cannot provide score values.
   float score() const { return score_; }
   void set_score(float score) { score_ = score; }
 
  private:
   std::string id_;
-  ContentSuggestionsProviderType provider_;
   ContentSuggestionCategory category_;
   GURL url_;
   GURL amp_url_;
   std::string title_;
   std::string snippet_text_;
   GURL salient_image_url_;
   base::Time publish_date_;
   std::string publisher_name_;
   float score_;
 
   DISALLOW_COPY_AND_ASSIGN(ContentSuggestion);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTION_H_