Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2102003002: Revert of [Devtools] Fixed websocket initiators (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
dgozman, allada
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Devtools] Fixed websocket initiators (patchset #4 id:100001 of https://codereview.chromium.org/2094903002/ ) Reason for revert: The test is very flaky. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fnetwork%2Fwebsocket%2Finitiator.html Original issue's description: > [Devtools] Fixed websocket initiators > > BUG=457811 > R=dgozman > > Committed: https://crrev.com/b08177119dcdbf407492ca84065a6cff32fd78b0 > Cr-Commit-Position: refs/heads/master@{#402313} TBR=dgozman@chromium.org,allada@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457811 Committed: https://crrev.com/9afc91518d0b52587817d0dc743f42453b0564f5 Cr-Commit-Position: refs/heads/master@{#402423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -97 lines) Patch
D third_party/WebKit/LayoutTests/inspector-protocol/network/websocket/initiator.html View 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/WebKit/LayoutTests/inspector-protocol/network/websocket/initiator-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/browser_protocol.json View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Created Revert of [Devtools] Fixed websocket initiators
4 years, 5 months ago (2016-06-28 08:01:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2102003002/1
4 years, 5 months ago (2016-06-28 08:01:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 08:02:05 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 08:04:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9afc91518d0b52587817d0dc743f42453b0564f5
Cr-Commit-Position: refs/heads/master@{#402423}

Powered by Google App Engine
This is Rietveld 408576698