Skip header lines with invalid header name

net/http/http_util_unittest.cc

Index: net/http/http_util_unittest.cc
diff --git a/net/http/http_util_unittest.cc b/net/http/http_util_unittest.cc
index 557d92367a1b28f13bb907e4c481648f102c05b7..c6ef864ddf6be3e64e1b79407eeaad2e99d63969 100644
--- a/net/http/http_util_unittest.cc
+++ b/net/http/http_util_unittest.cc
@@ -178,6 +178,27 @@ TEST(HttpUtilTest, HeadersIterator_MalformedLine) {
   EXPECT_FALSE(it.GetNext());
 }
 
+TEST(HttpUtilTest, HeadersIterator_MalformedName) {
+  {
+    std::string headers = "[ignore me] /: 3\r\n";
+
+    HttpUtil::HeadersIterator it(headers.begin(), headers.end(), "\r\n");
+
+    EXPECT_FALSE(it.GetNext());
+  }
+  {
+    std::string headers = "[ignore me] /: 3\r\nbar: 4\n";
+
+    HttpUtil::HeadersIterator it(headers.begin(), headers.end(), "\r\n");
+
+    ASSERT_TRUE(it.GetNext());
+    EXPECT_EQ(std::string("bar"), it.name());
+    EXPECT_EQ(std::string("4"), it.values());
+
+    EXPECT_FALSE(it.GetNext());
+  }

[mmenke, 2016/06/28 14:54:01]

Could you split this into two tests?  Not too concerned with what you call them
(HeadersIterator_MalformedName1 / HeadersIterator_MalformedName2, or
HeadersIterator_MalformedNameTwoHeaders for the second one, or whatever).

Just makes regressions marginally simpler to debug.

[robwu, 2016/06/28 15:24:42]

Done.

+}
+
 TEST(HttpUtilTest, HeadersIterator_AdvanceTo) {
   std::string headers = "foo: 1\r\n: 2\r\n3\r\nbar: 4";