Skip header lines with invalid header name

net/http/http_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/strings/string_util.h"
 #include "net/http/http_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 160 matching lines @@
   EXPECT_EQ(std::string("foo"), it.name());
   EXPECT_EQ(std::string("1"), it.values());
 
   ASSERT_TRUE(it.GetNext());
   EXPECT_EQ(std::string("bar"), it.name());
   EXPECT_EQ(std::string("4"), it.values());
 
   EXPECT_FALSE(it.GetNext());
 }
 
+TEST(HttpUtilTest, HeadersIterator_MalformedName) {
+  {
+    std::string headers = "[ignore me] /: 3\r\n";
+
+    HttpUtil::HeadersIterator it(headers.begin(), headers.end(), "\r\n");
+
+    EXPECT_FALSE(it.GetNext());
+  }
+  {
+    std::string headers = "[ignore me] /: 3\r\nbar: 4\n";
+
+    HttpUtil::HeadersIterator it(headers.begin(), headers.end(), "\r\n");
+
+    ASSERT_TRUE(it.GetNext());
+    EXPECT_EQ(std::string("bar"), it.name());
+    EXPECT_EQ(std::string("4"), it.values());
+
+    EXPECT_FALSE(it.GetNext());
+  }

[mmenke, 2016/06/28 14:54:01]

Could you split this into two tests?  Not too concerned with what you call them
(HeadersIterator_MalformedName1 / HeadersIterator_MalformedName2, or
HeadersIterator_MalformedNameTwoHeaders for the second one, or whatever).

Just makes regressions marginally simpler to debug.

[robwu, 2016/06/28 15:24:42]

Done.

+}
+
 TEST(HttpUtilTest, HeadersIterator_AdvanceTo) {
   std::string headers = "foo: 1\r\n: 2\r\n3\r\nbar: 4";
 
   HttpUtil::HeadersIterator it(headers.begin(), headers.end(), "\r\n");
   EXPECT_TRUE(it.AdvanceTo("foo"));
   EXPECT_EQ("foo", it.name());
   EXPECT_TRUE(it.AdvanceTo("bar"));
   EXPECT_EQ("bar", it.name());
   EXPECT_FALSE(it.AdvanceTo("blat"));
   EXPECT_FALSE(it.GetNext());  // should be at end of headers
@@ skipping 1173 matching lines @@
   EXPECT_TRUE(HttpUtil::HasValidators(v1_1, kEtagWeak, kLastModified));
   EXPECT_TRUE(HttpUtil::HasValidators(v1_1, kEtagEmpty, kLastModified));
 
   EXPECT_FALSE(HttpUtil::HasValidators(v1_1, kMissing, kLastModifiedInvalid));
   EXPECT_TRUE(HttpUtil::HasValidators(v1_1, kEtagStrong, kLastModifiedInvalid));
   EXPECT_TRUE(HttpUtil::HasValidators(v1_1, kEtagWeak, kLastModifiedInvalid));
   EXPECT_TRUE(HttpUtil::HasValidators(v1_1, kEtagEmpty, kLastModifiedInvalid));
 }
 
 }  // namespace net