Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 210193002: Ensure the constant operand for heap-object store-named-field is not a smi. (Closed)

Created:
6 years, 9 months ago by Toon Verwaest
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Ensure the constant operand for heap-object store-named-field is not a smi. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20208

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-store-heapobject.js View 1 chunk +17 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 9 months ago (2014-03-24 16:12:55 UTC) #1
Jakob Kummerow
lgtm
6 years, 9 months ago (2014-03-24 16:22:44 UTC) #2
Toon Verwaest
6 years, 9 months ago (2014-03-24 16:26:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20208 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698