src/x64/lithium-codegen-x64.cc - Issue 210193002: Ensure the constant operand for heap-object store-named-field is not a smi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 210193002: Ensure the constant operand for heap-object store-named-field is not a smi. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index 5849cf4ef910d6573c75dd7b4858a964e75192b9..638c26add6c6eea138056441e7a8de97981ebe73 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3966,7 +3966,7 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {

} else if (representation.IsHeapObject()) {

if (instr->value()->IsConstantOperand()) {

LConstantOperand* operand_value = LConstantOperand::cast(instr->value());

- if (IsInteger32Constant(operand_value)) {

+ if (chunk_->LookupConstant(operand_value)->HasSmiValue()) {

DeoptimizeIf(no_condition, instr->environment());

}

} else {

« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | test/mjsunit/regress/regress-store-heapobject.js » ('j') | no next file with comments »