[Remoting Android] DisplayUpdaterFactory cleanups

remoting/protocol/video_renderer.h

Index: remoting/protocol/video_renderer.h
diff --git a/remoting/protocol/video_renderer.h b/remoting/protocol/video_renderer.h
index 4f0eba9a69a2d513eba579fa102dfffa947bdb29..3ddd8722fa23a97f0351d6ee43ea6a20e27cf535 100644
--- a/remoting/protocol/video_renderer.h
+++ b/remoting/protocol/video_renderer.h
@@ -6,9 +6,11 @@
 #define REMOTING_CLIENT_VIDEO_RENDERER_H_
 
 namespace remoting {
-namespace protocol {
+class ClientContext;
 
+namespace protocol {
 class FrameConsumer;
+class PerformanceTracker;
 class SessionConfig;
 class VideoStub;
 
@@ -22,6 +24,13 @@ class VideoRenderer {
  public:
   virtual ~VideoRenderer() {}
 
+  // Initializes the video renderer. This allows the renderer to be initialized
+  // after it is constructed. It is up to the implementation and caller to
+  // either use this function or have their own initialization approach.
+  // |perf_tracker| must outlive the renderer.
+  virtual void Initialize(const ClientContext& client_context,

[Sergey Ulanov, 2016/06/28 17:59:50]

Return bool here as Initialization may fail (for the pepper implementation of
this interface).

[Yuwei, 2016/06/28 18:46:06]

Done.

+                          protocol::PerformanceTracker* perf_tracker) {}

[Sergey Ulanov, 2016/06/28 17:59:50]

Please make this pure virtual. Default stub implementation in an interface is
acceptable for optional methods in event-handler interfaces, but in most other
cases all methods in interfaces should be pure virtual.

[Yuwei, 2016/06/28 18:46:06]

Done.

+
   // Configures the renderer with the supplied |config|. This must be called
   // exactly once before video data is supplied to the renderer.
   virtual void OnSessionConfig(const SessionConfig& config) = 0;