[Remoting Android] DisplayUpdaterFactory cleanups

remoting/protocol/video_renderer.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CLIENT_VIDEO_RENDERER_H_
 #define REMOTING_CLIENT_VIDEO_RENDERER_H_
 
 namespace remoting {
+class ClientContext;
+
 namespace protocol {
-
 class FrameConsumer;
+class PerformanceTracker;
 class SessionConfig;
 class VideoStub;
 
 // VideoRenderer is responsible for decoding and displaying incoming video
 // stream. This interface is used by ConnectionToHost implementations to
 // render received video frames. ConnectionToHost may feed encoded frames to the
 // VideoStub or decode them and pass decoded frames to the FrameConsumer.
 //
 // TODO(sergeyu): Reconsider this design.
 class VideoRenderer {
  public:
   virtual ~VideoRenderer() {}
 
+  // Initializes the video renderer. This allows the renderer to be initialized
+  // after it is constructed. It is up to the implementation and caller to
+  // either use this function or have their own initialization approach.
+  // |perf_tracker| must outlive the renderer.
+  virtual void Initialize(const ClientContext& client_context,

[Sergey Ulanov, 2016/06/28 17:59:50]

Return bool here as Initialization may fail (for the pepper implementation of
this interface).

[Yuwei, 2016/06/28 18:46:06]

Done.

+                          protocol::PerformanceTracker* perf_tracker) {}

[Sergey Ulanov, 2016/06/28 17:59:50]

Please make this pure virtual. Default stub implementation in an interface is
acceptable for optional methods in event-handler interfaces, but in most other
cases all methods in interfaces should be pure virtual.

[Yuwei, 2016/06/28 18:46:06]

Done.

+
   // Configures the renderer with the supplied |config|. This must be called
   // exactly once before video data is supplied to the renderer.
   virtual void OnSessionConfig(const SessionConfig& config) = 0;
 
   // Returns the VideoStub interface of this renderer.
   virtual VideoStub* GetVideoStub() = 0;
 
   // Returns the FrameConsumer interface for this renderer.
   virtual FrameConsumer* GetFrameConsumer() = 0;
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_CLIENT_VIDEO_RENDERER_H_