Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 2101823003: Move SkColorSpace ICC parsing/writing code to its own file (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Move SkColorSpace ICC parsing/writing code to its own file BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2101823003 Committed: https://skia.googlesource.com/skia/+/085cad4abcca4e10dcc6ba95347c378d4c47fb90

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1376 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkColorSpace.cpp View 3 chunks +1 line, -1070 lines 0 comments Download
A src/core/SkColorSpacePriv.h View 1 chunk +25 lines, -0 lines 0 comments Download
A + src/core/SkColorSpace_ICC.cpp View 2 chunks +1 line, -306 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101823003/1
4 years, 5 months ago (2016-06-28 13:51:20 UTC) #3
msarett
4 years, 5 months ago (2016-06-28 13:51:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-28 14:07:10 UTC) #7
Brian Osman
Review diffs are confusing, but I think this lgtm.
4 years, 5 months ago (2016-06-28 14:14:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101823003/1
4 years, 5 months ago (2016-06-28 14:15:05 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 14:16:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/085cad4abcca4e10dcc6ba95347c378d4c47fb90

Powered by Google App Engine
This is Rietveld 408576698