Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2101743002: Observe input metrics from web content area. (Closed)

Created:
4 years, 5 months ago by Alexei Svitkine (slow)
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Observe input metrics from web content area. BUG=

Patch Set 1 : . #

Patch Set 2 : Patch in Patrick's V2 patchset. #

Patch Set 3 : hook things up #

Patch Set 4 : . #

Patch Set 5 : Add in visibility tracking based on BrowserList which was extended #

Patch Set 6 : update service logic for visibility stuff; add debug logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+412 lines, -2 lines) Patch
M chrome/browser/chrome_browser_main.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download
A chrome/browser/metrics/chrome_visibility_observer.h View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
A chrome/browser/metrics/chrome_visibility_observer.cc View 1 2 3 4 5 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/metrics/desktop_engagement_observer.h View 1 2 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/metrics/desktop_engagement_observer.cc View 1 2 3 1 chunk +57 lines, -0 lines 0 comments Download
A chrome/browser/metrics/desktop_engagement_service.h View 1 2 3 4 5 1 chunk +52 lines, -0 lines 0 comments Download
A chrome/browser/metrics/desktop_engagement_service.cc View 1 2 3 4 5 1 chunk +121 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list.cc View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_list_observer.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/tab_helpers.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (3 generated)
Alexei Svitkine (slow)
Description was changed from ========== . . BUG= ========== to ========== Observe input metrics from ...
4 years, 5 months ago (2016-06-27 21:27:27 UTC) #1
Alexei Svitkine (slow)
Patchset #1 (id:1) has been deleted
4 years, 5 months ago (2016-06-27 21:36:55 UTC) #2
Alexei Svitkine (slow)
4 years, 5 months ago (2016-06-28 17:45:46 UTC) #3
Patchset #1 (id:20001) has been deleted

Powered by Google App Engine
This is Rietveld 408576698