Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 2101743002: Observe input metrics from web content area. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update service logic for visibility stuff; add debug logging Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_list_observer.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm
index 4ab8af89a5846f6f22131b898c78520a55fe9f89..8278acd04491f8ab64cb4f239f213d1fa9e16aa6 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm
@@ -598,9 +598,9 @@ bool IsTabDetachingInFullscreenEnabled() {
// Called right after our window became the main window.
- (void)windowDidBecomeMain:(NSNotification*)notification {
- if (chrome::GetLastActiveBrowser() != browser_.get()) {
+// if (chrome::GetLastActiveBrowser() != browser_.get()) {
BrowserList::SetLastActive(browser_.get());
- }
+ //}
// Always saveWindowPositionIfNeeded when becoming main, not just
// when |browser_| is not the last active browser. See crbug.com/536280 .
[self saveWindowPositionIfNeeded];
@@ -624,6 +624,8 @@ bool IsTabDetachingInFullscreenEnabled() {
extensions::ExtensionCommandsGlobalRegistry::Get(browser_->profile())
->set_registry_for_active_window(nullptr);
+
+ BrowserList::NotifyBrowserNoLongerActive(browser_.get());
}
// Called when we have been minimized.
« no previous file with comments | « chrome/browser/ui/browser_list_observer.h ('k') | chrome/browser/ui/tab_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698