Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2101653003: [Turbofan] Simplify operand canonicalization on archs with simple FP aliasing. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Simplify operand canonicalization on archs with simple FP aliasing. - Changes InstructionOperand canonicalization to map all FP operands to kFloat64 on Intel and other platforms with simple aliasing. - Bypass expensive interference calculations and fixed FP live range processing for platforms with simple aliasing. LOG=N BUG=v8:4124 Committed: https://crrev.com/4b76dc85979094ac26499f2e527e422d4f0f6e58 Cr-Commit-Position: refs/heads/master@{#37388}

Patch Set 1 #

Patch Set 2 : Fix GetCanonicalizedValue. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -23 lines) Patch
M src/compiler/instruction.h View 1 2 2 chunks +11 lines, -5 lines 0 comments Download
M src/compiler/instruction.cc View 1 1 chunk +6 lines, -8 lines 0 comments Download
M src/compiler/move-optimizer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/register-allocator.cc View 1 2 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
bbudge
This should help reduce the impact of SIMD registers on non-ARM archs.
4 years, 5 months ago (2016-06-29 00:12:49 UTC) #6
bbudge
On 2016/06/29 00:12:49, bbudge wrote: > This should help reduce the impact of SIMD registers ...
4 years, 5 months ago (2016-06-29 00:14:57 UTC) #7
bbudge
On 2016/06/29 00:12:49, bbudge wrote: > This should help reduce the impact of SIMD registers ...
4 years, 5 months ago (2016-06-29 00:14:57 UTC) #8
Benedikt Meurer
Nice. LGTM.
4 years, 5 months ago (2016-06-29 03:41:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101653003/40001
4 years, 5 months ago (2016-06-29 11:45:09 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-29 11:47:16 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 11:49:15 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4b76dc85979094ac26499f2e527e422d4f0f6e58
Cr-Commit-Position: refs/heads/master@{#37388}

Powered by Google App Engine
This is Rietveld 408576698