Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: src/compiler/instruction.cc

Issue 2101653003: [Turbofan] Simplify operand canonicalization on archs with simple FP aliasing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/instruction.h ('k') | src/compiler/move-optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.cc
diff --git a/src/compiler/instruction.cc b/src/compiler/instruction.cc
index 5ca3600375aafd8f4b7bd5d55a0742235d732702..1ef42d6bccee432e02db647cbe9631b8c76e2177 100644
--- a/src/compiler/instruction.cc
+++ b/src/compiler/instruction.cc
@@ -61,16 +61,14 @@ FlagsCondition CommuteFlagsCondition(FlagsCondition condition) {
}
bool InstructionOperand::InterferesWith(const InstructionOperand& that) const {
- if (!IsFPRegister() || !that.IsFPRegister()) return EqualsCanonicalized(that);
-
+ if (!IsFPRegister() || !that.IsFPRegister() || kSimpleFPAliasing)
+ return EqualsCanonicalized(that);
+ // Both operands are fp registers and aliasing is non-simple.
const LocationOperand& loc1 = *LocationOperand::cast(this);
const LocationOperand& loc2 = LocationOperand::cast(that);
- const RegisterConfiguration* config = GetRegConfig();
- if (config->fp_aliasing_kind() != RegisterConfiguration::COMBINE)
- return loc1.register_code() == loc2.register_code();
-
- return config->AreAliases(loc1.representation(), loc1.register_code(),
- loc2.representation(), loc2.register_code());
+ return GetRegConfig()->AreAliases(loc1.representation(), loc1.register_code(),
+ loc2.representation(),
+ loc2.register_code());
}
void InstructionOperand::Print(const RegisterConfiguration* config) const {
« no previous file with comments | « src/compiler/instruction.h ('k') | src/compiler/move-optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698