Issue 2101623003: Stop using next_packet_sequence_number_length in QuicPacketCreator. No functional change. Protect…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2101623003: Stop using next_packet_sequence_number_length in QuicPacketCreator. No functional change. Protect… (Closed)

Created:
4 years, 5 months ago by Ryan Hamilton

Modified:
4 years, 5 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@125703498

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop using next_packet_sequence_number_length in QuicPacketCreator. No functional change. Protected by FLAGS_quic_simple_packet_number_length. Merge internal change: 125727775

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+169 lines, -32 lines)			Patch
M	net/quic/quic_connection.cc	View	2 chunks	+16 lines, -6 lines	0 comments	Download
M	net/quic/quic_flags.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_flags.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/quic/quic_packet_creator.cc	View	9 chunks	+42 lines, -13 lines	0 comments	Download
M	net/quic/quic_packet_creator_test.cc	View	10 chunks	+106 lines, -13 lines	0 comments	Download

Depends on Patchset:

Issue 2099403002 Patch 1

Dependent Patchsets:

Issue 2099313003 Patch 1

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages