Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 21016005: WebCrypto: Add more operations to the platform API. (Closed)

Created:
7 years, 4 months ago by eroman
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, jamesr, dglazkov+blink, eae+blinkwatch, abarth-chromium
Visibility:
Public.

Description

WebCrypto: Add more operations to the platform API. Adds methods for encrypt(), decrypt() and sign() BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155224

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add notImplemented() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -30 lines) Patch
M Source/modules/crypto/Key.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/SubtleCrypto.cpp View 1 4 chunks +51 lines, -27 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/MockWebCrypto.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/chromium/TestRunner/src/MockWebCrypto.cpp View 1 chunk +15 lines, -0 lines 0 comments Download
M public/platform/WebCrypto.h View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
7 years, 4 months ago (2013-07-30 22:34:40 UTC) #1
abarth-chromium
Is there no way to test this CL? https://codereview.chromium.org/21016005/diff/6001/Source/modules/crypto/SubtleCrypto.cpp File Source/modules/crypto/SubtleCrypto.cpp (right): https://codereview.chromium.org/21016005/diff/6001/Source/modules/crypto/SubtleCrypto.cpp#newcode133 Source/modules/crypto/SubtleCrypto.cpp:133: // ...
7 years, 4 months ago (2013-07-31 00:59:59 UTC) #2
eroman
I can add testing for this one, however it will mean implementing some more extra ...
7 years, 4 months ago (2013-07-31 01:23:15 UTC) #3
abarth-chromium
LGTM I prefer small CLs if it's not too much overhead for you. The ideal ...
7 years, 4 months ago (2013-07-31 01:31:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/21016005/12001
7 years, 4 months ago (2013-07-31 01:33:42 UTC) #5
commit-bot: I haz the power
7 years, 4 months ago (2013-07-31 05:45:04 UTC) #6
Message was sent while issue was closed.
Change committed as 155224

Powered by Google App Engine
This is Rietveld 408576698