WebCrypto: Add more operations to the platform API.

Source/modules/crypto/SubtleCrypto.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 31 matching lines @@
 #include "wtf/ArrayBufferView.h"
 
 namespace WebCore {
 
 // FIXME: Outstanding KeyOperations and CryptoOperations should be aborted when
 // tearing down SubtleCrypto (to avoid problems completing a
 // ScriptPromiseResolver which is no longer valid).
 
 namespace {
 
-// FIXME: Temporary
-PassRefPtr<CryptoOperation> dummyOperation(const Dictionary& rawAlgorithm, AlgorithmOperation operationType, ExceptionState& es)
+bool keyCanBeUsedForAlgorithm(const WebKit::WebCryptoKey& key, const WebKit::WebCryptoAlgorithm& algorithm, ExceptionState& es)
+{
+    // FIXME: Need to enforce that the key's algorithm matches the operation,
+    // and that the key's usages allow it to be used with this operation.
+    return true;
+}
+
+PassRefPtr<CryptoOperation> createCryptoOperation(const Dictionary& rawAlgorithm, Key* key, AlgorithmOperation operationType, ExceptionState& es)
 {
     WebKit::WebCrypto* platformCrypto = WebKit::Platform::current()->crypto();
     if (!platformCrypto) {
         es.throwDOMException(NotSupportedError);
         return 0;
     }
 
     WebKit::WebCryptoAlgorithm algorithm;
     if (!normalizeAlgorithm(rawAlgorithm, operationType, algorithm, es))
         return 0;
 
+    // All operations other than Digest require a valid Key.
+    if (operationType != Digest) {
+        if (!key) {
+            es.throwDOMException(TypeError);
+            return 0;
+        }
+
+        if (!keyCanBeUsedForAlgorithm(key->key(), algorithm, es)) {
+            return 0;
+        }
+    }
+
     RefPtr<CryptoOperationImpl> opImpl = CryptoOperationImpl::create();
     WebKit::WebCryptoOperationResult result(opImpl.get());
-    platformCrypto->digest(algorithm, result);
+
+    switch (operationType) {
+    case Encrypt:
+        platformCrypto->encrypt(algorithm, key->key(), result);
+        break;
+    case Decrypt:
+        platformCrypto->decrypt(algorithm, key->key(), result);
+        break;
+    case Sign:
+        platformCrypto->sign(algorithm, key->key(), result);
+        break;
+    case Digest:
+        platformCrypto->digest(algorithm, result);
+        break;
+    default:
+        ASSERT_NOT_REACHED();
+        return 0;
+    }
+
     if (opImpl->throwInitializationError(es))
         return 0;
     return CryptoOperation::create(algorithm, opImpl.get());
 }
 
 } // namespace
 
 SubtleCrypto::SubtleCrypto()
 {
     ScriptWrappable::init(this);
 }
 
-PassRefPtr<CryptoOperation> SubtleCrypto::encrypt(const Dictionary& rawAlgorithm, Key*, ExceptionState& es)
+PassRefPtr<CryptoOperation> SubtleCrypto::encrypt(const Dictionary& rawAlgorithm, Key* key, ExceptionState& es)
 {
-    return dummyOperation(rawAlgorithm, Encrypt, es);
+    return createCryptoOperation(rawAlgorithm, key, Encrypt, es);
 }
 
-PassRefPtr<CryptoOperation> SubtleCrypto::decrypt(const Dictionary& rawAlgorithm, Key*, ExceptionState& es)
+PassRefPtr<CryptoOperation> SubtleCrypto::decrypt(const Dictionary& rawAlgorithm, Key* key, ExceptionState& es)
 {
-    return dummyOperation(rawAlgorithm, Decrypt, es);
+    return createCryptoOperation(rawAlgorithm, key, Decrypt, es);
 }
 
-PassRefPtr<CryptoOperation> SubtleCrypto::sign(const Dictionary& rawAlgorithm, Key*, ExceptionState& es)
+PassRefPtr<CryptoOperation> SubtleCrypto::sign(const Dictionary& rawAlgorithm, Key* key, ExceptionState& es)
 {
-    return dummyOperation(rawAlgorithm, Sign, es);
+    return createCryptoOperation(rawAlgorithm, key, Sign, es);
 }
 
-PassRefPtr<CryptoOperation> SubtleCrypto::verifySignature(const Dictionary& rawAlgorithm, Key*, ExceptionState& es)
+PassRefPtr<CryptoOperation> SubtleCrypto::verifySignature(const Dictionary& rawAlgorithm, Key* key, ExceptionState& es)
 {
-    return dummyOperation(rawAlgorithm, Verify, es);
+    // FIXME

[abarth-chromium, 2013/07/31 00:59:59]

Rather than an empty FIXME comment, you can call the notImplemented() function. 
That doesn't do anything, but it's a more accurate description of what's going
on here.

[eroman, 2013/07/31 01:23:16]

Done.

+    return 0;
 }
 
 PassRefPtr<CryptoOperation> SubtleCrypto::digest(const Dictionary& rawAlgorithm, ExceptionState& es)
 {
-    WebKit::WebCrypto* platformCrypto = WebKit::Platform::current()->crypto();
-    if (!platformCrypto) {
-        es.throwDOMException(NotSupportedError);
-        return 0;
-    }
-
-    WebKit::WebCryptoAlgorithm algorithm;
-    if (!normalizeAlgorithm(rawAlgorithm, Digest, algorithm, es))
-        return 0;
-
-    RefPtr<CryptoOperationImpl> opImpl = CryptoOperationImpl::create();
-    WebKit::WebCryptoOperationResult result(opImpl.get());
-    platformCrypto->digest(algorithm, result);
-    if (opImpl->throwInitializationError(es))
-        return 0;
-    return CryptoOperation::create(algorithm, opImpl.get());
+    return createCryptoOperation(rawAlgorithm, 0, Digest, es);
 }
 
 ScriptObject SubtleCrypto::importKey(const String& rawFormat, ArrayBufferView* keyData, const Dictionary& rawAlgorithm, bool extractable, const Vector<String>& rawKeyUsages, ExceptionState& es)
 {
     WebKit::WebCrypto* platformCrypto = WebKit::Platform::current()->crypto();
     if (!platformCrypto) {
         es.throwDOMException(NotSupportedError);
         return ScriptObject();
     }
 
@@ skipping 20 matching lines @@
 
     const unsigned char* keyDataBytes = static_cast<unsigned char*>(keyData->baseAddress());
 
     RefPtr<KeyOperation> keyOp = KeyOperation::create();
     WebKit::WebCryptoKeyOperationResult result(keyOp.get());
     platformCrypto->importKey(format, keyDataBytes, keyData->byteLength(), algorithm, extractable, keyUsages, result);
     return keyOp->returnValue(es);
 }
 
 } // namespace WebCore