Re-land: exo: Take blending into account when setting opaque property.

Re-land: exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781
Committed: https://crrev.com/88b27fc74532f7d4aeb273189bc20fb8f233fb60
Cr-Commit-Position: refs/heads/master@{#402648}

[reveman, 2016-06-26 17:19:34]

reveman@chromium.org changed reviewers:
+ jbauman@chromium.org

[reveman, 2016-06-26 17:19:47]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-26 17:19:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-26 17:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-26 17:52:53]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-06-27 20:51:41]

lgtm

https://codereview.chromium.org/2101453002/diff/1/components/exo/surface.cc
File components/exo/surface.cc (left):

https://codereview.chromium.org/2101453002/diff/1/components/exo/surface.cc#o...
components/exo/surface.cc:480: state_.alpha == 1.0f &&
So if the blend mode is SkXfermode::kSrc_Mode then the alpha should be ignored?
And the opaque_region should always be empty if alpha is not 1.0?

[reveman, 2016-06-27 20:54:21]

The CQ bit was checked by reveman@chromium.org

[reveman, 2016-06-27 20:54:21]

https://codereview.chromium.org/2101453002/diff/1/components/exo/surface.cc
File components/exo/surface.cc (left):

https://codereview.chromium.org/2101453002/diff/1/components/exo/surface.cc#o...
components/exo/surface.cc:480: state_.alpha == 1.0f &&
On 2016/06/27 at 20:51:41, jbauman wrote:
> So if the blend mode is SkXfermode::kSrc_Mode then the alpha should be
ignored? And the opaque_region should always be empty if alpha is not 1.0?

We should probably define this as part of the alpha blending interface we added.
For now we can say that if the client sets alpha to less than 1 and opaque to
true then output is undefined.

[commit-bot: I haz the power, 2016-06-27 20:55:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 23:57:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 23:57:44]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2016-06-28 08:34:45]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-06-28 08:34:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 09:08:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-28 09:10:35]

Description was changed from

==========
exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781
==========

to

==========
exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781

Committed: https://crrev.com/d418b059202ca86880ed287b9a33f6d947123691
Cr-Commit-Position: refs/heads/master@{#402430}
==========

[commit-bot: I haz the power, 2016-06-28 09:10:37]

Patchset 1 (id:??) landed as
https://crrev.com/d418b059202ca86880ed287b9a33f6d947123691
Cr-Commit-Position: refs/heads/master@{#402430}

[Pete Williamson, 2016-06-28 17:02:20]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2109703002/ by petewil@chromium.org.

The reason for reverting is: This seems to be causing ChromiumOS waterfall
trybots to fail, Reverting as Sheriff.

Failure logs here:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...


.

[reveman, 2016-06-28 22:14:03]

Description was changed from

==========
exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781

Committed: https://crrev.com/d418b059202ca86880ed287b9a33f6d947123691
Cr-Commit-Position: refs/heads/master@{#402430}
==========

to

==========
Re-land: exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781
==========

[reveman, 2016-06-28 22:15:37]

On 2016/06/28 at 17:02:20, petewil wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2109703002/ by petewil@chromium.org.
> 
> The reason for reverting is: This seems to be causing ChromiumOS waterfall
trybots to fail, Reverting as Sheriff.
> 
> Failure logs here:
https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%...

> 
> .

fyi, relanding after fixing the unit test

[reveman, 2016-06-28 22:15:41]

The CQ bit was checked by reveman@chromium.org

[reveman, 2016-06-28 22:15:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jbauman@chromium.org
Link to the patchset: https://codereview.chromium.org/2101453002/#ps20001
(title: "fix unit test")

[commit-bot: I haz the power, 2016-06-28 22:17:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 00:09:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 00:09:18]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[reveman, 2016-06-29 00:37:59]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-06-29 00:39:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 01:57:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 02:00:44]

Description was changed from

==========
Re-land: exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781
==========

to

==========
Re-land: exo: Take blending into account when setting opaque property.

This makes SetFillsBoundsOpaquely() call consistent with opaque_rect
used in UpdateSurface() when creating a texture quad.

BUG=549781

Committed: https://crrev.com/88b27fc74532f7d4aeb273189bc20fb8f233fb60
Cr-Commit-Position: refs/heads/master@{#402648}
==========

[commit-bot: I haz the power, 2016-06-29 02:00:45]

Patchset 2 (id:??) landed as
https://crrev.com/88b27fc74532f7d4aeb273189bc20fb8f233fb60
Cr-Commit-Position: refs/heads/master@{#402648}