components/exo/surface.cc - Issue 2101453002: Re-land: exo: Take blending into account when setting opaque property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/exo/surface.cc

Issue 2101453002: Re-land: exo: Take blending into account when setting opaque property. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/exo/surface.cc

diff --git a/components/exo/surface.cc b/components/exo/surface.cc

index cf36bba64303ec95d5a188eaec4012012912fa9a..fed879a6684f54aefae2409c2da414d953a50a23 100644

--- a/components/exo/surface.cc

+++ b/components/exo/surface.cc

@@ -485,8 +485,7 @@ void Surface::CommitSurfaceHierarchy() {

window_->layer()->SetBounds(

gfx::Rect(window_->layer()->bounds().origin(), content_size_));

window_->layer()->SetFillsBoundsOpaquely(

- state_.alpha == 1.0f &&

+ state_.blend_mode == SkXfermode::kSrc_Mode ||

state_.opaque_region.contains(

gfx::RectToSkIRect(gfx::Rect(content_size_))));

}

« no previous file with comments | « no previous file | components/exo/surface_unittest.cc » ('j') | no next file with comments »