Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2101403005: media: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, hubbe, dcheng
CC:
chromium-reviews, qsr+mojo_chromium.org, toyoshim+midi_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, alokp+watch_chromium.org, eme-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=hubbe, danakj, dcheng BUG=554600 Committed: https://crrev.com/ea7a7551eb59fb06ae5a488ee20faf91b2695d7d Cr-Commit-Position: refs/heads/master@{#402640}

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -21 lines) Patch
M media/base/audio_bus_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M media/base/video_capture_types.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cdm/aes_decryptor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M media/midi/midi_manager_alsa.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/renderers/skcanvas_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:38:15 UTC) #2
hubbe
LGTM (with one minor fix) https://codereview.chromium.org/2101403005/diff/1/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/2101403005/diff/1/media/filters/ffmpeg_demuxer.cc#newcode1614 media/filters/ffmpeg_demuxer.cc:1614: for (auto* stream : ...
4 years, 5 months ago (2016-06-28 21:49:46 UTC) #3
vmpstr
https://codereview.chromium.org/2101403005/diff/1/media/filters/ffmpeg_demuxer.cc File media/filters/ffmpeg_demuxer.cc (right): https://codereview.chromium.org/2101403005/diff/1/media/filters/ffmpeg_demuxer.cc#newcode1614 media/filters/ffmpeg_demuxer.cc:1614: for (auto* stream : streams_) { // |stream| is ...
4 years, 5 months ago (2016-06-28 22:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101403005/20001
4 years, 5 months ago (2016-06-28 22:36:44 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 01:51:21 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 01:54:21 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ea7a7551eb59fb06ae5a488ee20faf91b2695d7d
Cr-Commit-Position: refs/heads/master@{#402640}

Powered by Google App Engine
This is Rietveld 408576698