Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: media/midi/midi_manager.cc

Issue 2101403005: media: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove comment Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/source_buffer_stream.cc ('k') | media/midi/midi_manager_alsa.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager.cc
diff --git a/media/midi/midi_manager.cc b/media/midi/midi_manager.cc
index ad7dba1ef5a3b070d6122d44c13612c2515a1a72..12d4d0764524a5bd845e1146c942f1ec3a21cf1f 100644
--- a/media/midi/midi_manager.cc
+++ b/media/midi/midi_manager.cc
@@ -189,7 +189,7 @@ void MidiManager::AddInputPort(const MidiPortInfo& info) {
ReportUsage(Usage::INPUT_PORT_ADDED);
base::AutoLock auto_lock(lock_);
input_ports_.push_back(info);
- for (auto client : clients_)
+ for (auto* client : clients_)
client->AddInputPort(info);
}
@@ -197,7 +197,7 @@ void MidiManager::AddOutputPort(const MidiPortInfo& info) {
ReportUsage(Usage::OUTPUT_PORT_ADDED);
base::AutoLock auto_lock(lock_);
output_ports_.push_back(info);
- for (auto client : clients_)
+ for (auto* client : clients_)
client->AddOutputPort(info);
}
@@ -205,7 +205,7 @@ void MidiManager::SetInputPortState(uint32_t port_index, MidiPortState state) {
base::AutoLock auto_lock(lock_);
DCHECK_LT(port_index, input_ports_.size());
input_ports_[port_index].state = state;
- for (auto client : clients_)
+ for (auto* client : clients_)
client->SetInputPortState(port_index, state);
}
@@ -213,7 +213,7 @@ void MidiManager::SetOutputPortState(uint32_t port_index, MidiPortState state) {
base::AutoLock auto_lock(lock_);
DCHECK_LT(port_index, output_ports_.size());
output_ports_[port_index].state = state;
- for (auto client : clients_)
+ for (auto* client : clients_)
client->SetOutputPortState(port_index, state);
}
@@ -223,7 +223,7 @@ void MidiManager::ReceiveMidiData(uint32_t port_index,
double timestamp) {
base::AutoLock auto_lock(lock_);
- for (auto client : clients_)
+ for (auto* client : clients_)
client->ReceiveMidiData(port_index, data, length, timestamp);
}
@@ -243,7 +243,7 @@ void MidiManager::CompleteInitializationInternal(Result result) {
initialized_ = true;
result_ = result;
- for (auto client : pending_clients_) {
+ for (auto* client : pending_clients_) {
if (result_ == Result::OK) {
AddInitialPorts(client);
clients_.insert(client);
@@ -268,7 +268,7 @@ void MidiManager::ShutdownOnSessionThread() {
finalized_ = true;
// Detach all clients so that they do not call MidiManager methods any more.
- for (auto client : clients_)
+ for (auto* client : clients_)
client->Detach();
}
« no previous file with comments | « media/filters/source_buffer_stream.cc ('k') | media/midi/midi_manager_alsa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698