src/hydrogen-instructions.h - Issue 21014003: Optionally use 31-bits SMI value for 64-bit system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.h

Issue 21014003: Optionally use 31-bits SMI value for 64-bit system (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed danno's comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.h

diff --git a/src/hydrogen-instructions.h b/src/hydrogen-instructions.h

index b7857244a5ac3c79aa62b71fb00e3a0a4499d691..7ddf8203159f23cc82eb19683d9a49a75f41005f 100644

--- a/src/hydrogen-instructions.h

+++ b/src/hydrogen-instructions.h

@@ -3342,7 +3342,7 @@ class HConstant: public HTemplateInstruction<0> {

}

virtual Representation KnownOptimalRepresentation() {

- if (HasSmiValue() && kSmiValueSize == 31) return Representation::Smi();

+ if (HasSmiValue() && SmiValuesAre31Bits()) return Representation::Smi();

if (HasInteger32Value()) return Representation::Integer32();

if (HasNumberValue()) return Representation::Double();

if (HasExternalReferenceValue()) return Representation::External();