src/hydrogen-instructions.cc - Issue 21014003: Optionally use 31-bits SMI value for 64-bit system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen-instructions.cc

Issue 21014003: Optionally use 31-bits SMI value for 64-bit system (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed danno's comments Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen-instructions.cc

diff --git a/src/hydrogen-instructions.cc b/src/hydrogen-instructions.cc

index 8c70a34f569b3a6d2fc3e301ba01c7419f090c26..eeb61741040396ec5621fabf08bcd399852ff651 100644

--- a/src/hydrogen-instructions.cc

+++ b/src/hydrogen-instructions.cc

@@ -2405,7 +2405,7 @@ HConstant::HConstant(ExternalReference reference)

void HConstant::Initialize(Representation r) {

if (r.IsNone()) {

- if (has_smi_value_ && kSmiValueSize == 31) {

+ if (has_smi_value_ && SmiValuesAre31Bits()) {

r = Representation::Smi();

} else if (has_int32_value_) {

r = Representation::Integer32();