Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2101363002: Disable HeapTest.TraceDeepEagerly for Android targets. (Closed)

Created:
4 years, 5 months ago by sof
Modified:
4 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable HeapTest.TraceDeepEagerly for Android targets. This test is heavy on allocation and considered too slow to be running w/ asserts enabled. Disable it entirely for Android, as the overhead is bogging down bots too much. R= BUG=623779 Committed: https://crrev.com/4104ca9695921544d1d605d4fea76f0147dd2d48 Cr-Commit-Position: refs/heads/master@{#402470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 5 months ago (2016-06-28 13:24:13 UTC) #2
haraken
LGTM
4 years, 5 months ago (2016-06-28 14:51:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101363002/1
4 years, 5 months ago (2016-06-28 15:01:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-28 15:06:29 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 15:08:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4104ca9695921544d1d605d4fea76f0147dd2d48
Cr-Commit-Position: refs/heads/master@{#402470}

Powered by Google App Engine
This is Rietveld 408576698