Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapTest.cpp

Issue 2101363002: Disable HeapTest.TraceDeepEagerly for Android targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/HeapTest.cpp
diff --git a/third_party/WebKit/Source/platform/heap/HeapTest.cpp b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
index 806293c5b1ec41889ac3a518e50804af0ab90ff4..c02c9d98a66fe09357832cc6aa6ec11052096c39 100644
--- a/third_party/WebKit/Source/platform/heap/HeapTest.cpp
+++ b/third_party/WebKit/Source/platform/heap/HeapTest.cpp
@@ -6286,7 +6286,10 @@ int DeepEagerly::sTraceLazy = 0;
TEST(HeapTest, TraceDeepEagerly)
{
-#if !ENABLE(ASSERT)
+ // The allocation & GC overhead is considerable for this test,
+ // straining debug builds and lower-end targets too much to be
+ // worth running.
+#if !ENABLE(ASSERT) && !OS(ANDROID)
DeepEagerly* obj = nullptr;
for (int i = 0; i < 10000000; i++)
obj = new DeepEagerly(obj);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698