Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 210133002: Remove the include "core/events/ThreadLocalEventNames.h" (Closed)

Created:
6 years, 9 months ago by riju_
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, ericu+idb_chromium.org, shans, jsbell+idb_chromium.org, tzik, gasubic, eae+blinkwatch, fs, eric.carlson_apple.com, nessy, apavlov+blink_chromium.org, adamk+blink_chromium.org, kinuko+watch, Steve Block, dino_apple.com, rune+blink, Nils Barth (inactive), jsbell+serviceworker_chromium.org, Nate Chapin, arv+blink, alancutter (OOO until 2018), marja+watch_chromium.org, dsinclair, alecflett, dglazkov+blink, abarth-chromium, aandrey+blink_chromium.org, dstockwell, Timothy Loh, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, pdr., rwlbuis, Eric Willigers, mvanouwerkerk+watch_chromium.org, philipj_slow, rjwright, dgrogan, zoltan1, sof, kouhei+svg_chromium.org, Raymond Toy, timvolodine, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, krit, gyuyoung.kim_webkit.org, darktears, haraken, kojih, vcarbune.chromium, alecflett+watch_chromium.org, kinuko, jsbell+bindings_chromium.org, nhiroki, bemjb+rendering_chromium.org, kouhei+bindings_chromium.org, leviw+renderwatch, serviceworker-reviews, falken, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Inactive, cmumford, groby+blinkspell_chromium.org, horo+watch_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the include "core/events/ThreadLocalEventNames.h" Only EventTarget.h needs this include This is a follow up patch for this CL by Adam Barth https://codereview.chromium.org/26890003 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -136 lines) Patch
M Source/bindings/v8/ScriptController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/V8AbstractEventListener.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/V8ErrorHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/custom/V8EventCustom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFaceLoadEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/FontFaceSet.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/CharacterData.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/WheelController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/AutocompleteErrorEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/BeforeLoadEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/BeforeTextInsertedEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/BeforeUnloadEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/ClipboardEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/CompositionEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/CustomEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/DOMWindowEventQueue.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/ErrorEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/Event.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/FocusEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/HashChangeEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/KeyboardEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/MouseEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/MutationEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/OverflowEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/PageTransitionEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/PopStateEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/ProgressEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/SecurityPolicyViolationEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/TextEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/TouchEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/TransitionEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/WebKitAnimationEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/WheelEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLImageLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/MediaDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/MediaKeyEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TrackEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderFrameSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/speech/SpeechInputEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/storage/StorageArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/storage/StorageEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGDocument.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGImageLoader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGScriptElement.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGZoomEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/AbstractWorker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/Worker.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationController.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/gamepad/GamepadEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFToneChangeEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/FetchEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/AudioProcessingEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioCompletionEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/websockets/CloseEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/SharedWorkerRepositoryClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
riju_
6 years, 9 months ago (2014-03-25 09:40:22 UTC) #1
abarth-chromium
lgtm Thanks!
6 years, 9 months ago (2014-03-25 15:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/210133002/1
6 years, 9 months ago (2014-03-25 15:19:47 UTC) #3
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 15:32:57 UTC) #4
Message was sent while issue was closed. 
Change committed as 169950

Powered by Google App Engine
This is Rietveld 408576698