Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 26890003: Remove ThreadLocalEventNames (Closed)

Created:
7 years, 2 months ago by abarth-chromium
Modified:
7 years, 2 months ago
Reviewers:
eseidel
CC:
blink-reviews, shans, eae+blinkwatch, nessy, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, Steve Block, dino_apple.com, Nils Barth (inactive), Nate Chapin, chromiumbugtracker_adobe.com, marja+watch_chromium.org, alecflett, dglazkov+blink, aandrey+blink_chromium.org, dstockwell, Timothy Loh, Rik, gavinp+loader_chromium.org, Eric Willigers, alancutter (OOO until 2018), rjwright, kinuko, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, darktears, haraken, kojih, vcarbune.chromium, jsbell, jsbell+bindings_chromium.org, Mike Lawther (Google), f(malita), Inactive, dgrogan, Stephen Chennney
Visibility:
Public.

Description

Remove ThreadLocalEventNames This CL removes the ThreadLocalEventNames class and moves all callers over to using thread-safe strings. I've left ThreadLocalEventNames.h in place because many files use it to pull in headers. I'll remove it in a future CL. R=eseidel@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159480

Patch Set 1 #

Patch Set 2 : Add missing include #

Patch Set 3 : rebase #

Patch Set 4 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -202 lines) Patch
M Source/bindings/v8/V8ErrorHandler.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8EventCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/custom/V8EventTargetCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/build/scripts/make_names.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/Init.cpp View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/core.gyp View 1 2 3 1 chunk +11 lines, -6 lines 0 comments Download
M Source/core/core.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSFontFaceLoadEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/FontFaceSet.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMNamedFlowCollection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedFlow.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/events/AutocompleteErrorEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/BeforeLoadEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/BeforeTextInsertedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/BeforeUnloadEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ClipboardEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/CompositionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/CustomEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ErrorEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/Event.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/FocusEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/HashChangeEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/KeyboardEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MouseEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/MutationEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/OverflowEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/PageTransitionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/PopStateEvent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ProgressEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ResourceProgressEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/SecurityPolicyViolationEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/TextEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/TextEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/ThreadLocalEventNames.h View 1 chunk +8 lines, -27 lines 0 comments Download
D Source/core/events/ThreadLocalEventNames.cpp View 1 chunk +0 lines, -36 lines 0 comments Download
M Source/core/events/TouchEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/TransitionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/UIEvent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/WebKitAnimationEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/WheelEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaKeyEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/WebGLContextEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackCue.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackList.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TrackBase.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TrackEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/appcache/ApplicationCache.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/ThreadGlobalData.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/platform/ThreadGlobalData.cpp View 3 chunks +1 line, -4 lines 0 comments Download
M Source/core/speech/SpeechInputEvent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/storage/StorageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementInstance.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGZoomEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/timing/Performance.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/DedicatedWorkerGlobalScope.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/Worker.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestProgressEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequestUpload.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceMotionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/device_orientation/DeviceOrientationEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyNeededEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/filesystem/FileWriter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBOpenDBRequest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBPendingTransactionMonitor.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBTransaction.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBVersionChangeEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/SourceBufferList.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitMediaSource.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediasource/WebKitSourceBufferList.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaConstraintsImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/mediastream/MediaStream.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrack.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/MediaStreamTrackEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFSender.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDTMFToneChangeEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannel.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCDataChannelEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCIceCandidateEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionError.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechRecognitionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/speech/SpeechSynthesisUtterance.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioNode.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioProcessingEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioCompletionEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIAccess.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIConnectionEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIInput.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webmidi/MIDIPort.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/CloseEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/WebSocket.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDOMEvent.cpp View 4 chunks +12 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
abarth-chromium
7 years, 2 months ago (2013-10-10 19:58:12 UTC) #1
eseidel
lgtm
7 years, 2 months ago (2013-10-10 20:20:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26890003/3001
7 years, 2 months ago (2013-10-10 20:20:33 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-10 20:38:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26890003/3001
7 years, 2 months ago (2013-10-10 20:49:19 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-10 20:51:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26890003/3001
7 years, 2 months ago (2013-10-10 21:55:30 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-10 22:14:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26890003/3001
7 years, 2 months ago (2013-10-11 00:02:43 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-11 00:18:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26890003/32001
7 years, 2 months ago (2013-10-11 17:36:48 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-11 18:10:38 UTC) #12
abarth-chromium
Now with 60% more compile. :)
7 years, 2 months ago (2013-10-11 18:43:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/26890003/44001
7 years, 2 months ago (2013-10-11 18:43:20 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=10539
7 years, 2 months ago (2013-10-11 22:47:21 UTC) #15
abarth-chromium
7 years, 2 months ago (2013-10-11 22:53:29 UTC) #16
Message was sent while issue was closed.
Committed patchset #4 manually as r159480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698