Pass delay and timestamp to AudioSourceCallback::OnMoreData.

media/audio/android/opensles_output.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/audio/android/opensles_output.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
+#include "base/time/time.h"
 #include "base/trace_event/trace_event.h"
 #include "media/audio/android/audio_manager_android.h"
 
 #define LOG_ON_FAILURE_AND_RETURN(op, ...)      \
   do {                                          \
     SLresult err = (op);                        \
     if (err != SL_RESULT_SUCCESS) {             \
       DLOG(ERROR) << #op << " failed: " << err; \
       return __VA_ARGS__;                       \
     }                                           \
@@ skipping 314 matching lines @@
 }
 
 void OpenSLESOutputStream::FillBufferQueueNoLock() {
   // Ensure that the calling thread has acquired the lock since it is not
   // done in this method.
   lock_.AssertAcquired();
 
   // Calculate the position relative to the number of frames written.
   uint32_t position_in_ms = 0;
   SLresult err = (*player_)->GetPosition(player_, &position_in_ms);
-  const int delay =
+  const base::TimeTicks target_playout_time =
       err == SL_RESULT_SUCCESS
-          ? -delay_calculator_.GetFramesToTarget(
-                base::TimeDelta::FromMilliseconds(position_in_ms)) *
-                bytes_per_frame_
-          : 0;
-  DCHECK_GE(delay, 0);
+          ? base::TimeTicks::Now() -

[chcunningham, 2016/07/29 01:21:09]

I don't follow your math here. I think what you want is to compute the delay as
we did before, then compute the target_playout_time = Now + delay. (same as in
also_output.cc)

[jameswest, 2016/08/26 02:08:47]

Done.

+                base::TimeDelta::FromMilliseconds(position_in_ms)
+          : base::TimeTicks();

[chcunningham, 2016/07/29 01:21:09]

I don't think you want 0 ticks here. I think you want Now()

[jameswest, 2016/08/26 02:08:47]

Done.

+  DCHECK_GE(target_playout_time, base::TimeTicks());

[chcunningham, 2016/07/29 01:21:09]

Still use this to check delay >= 0 if you take my recommendation for lines 346

[jameswest, 2016/08/26 02:08:47]

Done.

 
   // Read data from the registered client source.
-  const int frames_filled = callback_->OnMoreData(audio_bus_.get(), delay, 0);
+  const int frames_filled = callback_->OnMoreData(delay, 0, audio_bus_.get());
   if (frames_filled <= 0) {
     // Audio source is shutting down, or halted on error.
     return;
   }
 
   // Note: If the internal representation ever changes from 16-bit PCM to
   // raw float, the data must be clipped and sanitized since it may come
   // from an untrusted source such as NaCl.
   audio_bus_->Scale(muted_ ? 0.0f : volume_);
   audio_bus_->ToInterleaved(frames_filled, format_.bitsPerSample / 8,
@@ skipping 31 matching lines @@
   }
 }
 
 void OpenSLESOutputStream::HandleError(SLresult error) {
   DLOG(ERROR) << "OpenSLES Output error " << error;
   if (callback_)
     callback_->OnError(this);
 }
 
 }  // namespace media