Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 2101263003: base: Change auto to not deduce raw pointers. (Closed)

Created:
4 years, 5 months ago by vmpstr
Modified:
4 years, 5 months ago
Reviewers:
danakj, dcheng
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

base: Change auto to not deduce raw pointers. This patch updates the code to prevent auto deducing to a raw pointer. R=danakj, dcheng BUG=554600 Committed: https://crrev.com/5170bf98eb5ad7c6ebbdad175ecd478c3e48ead0 Cr-Commit-Position: refs/heads/master@{#402660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M base/metrics/statistics_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/heap_profiler_allocation_context_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/malloc_dump_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_dump_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/trace_event/process_memory_dump_unittest.cc View 4 chunks +17 lines, -17 lines 0 comments Download
M base/trace_event/trace_event_argument.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/trace_event/trace_log.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
vmpstr
Please take a look.
4 years, 5 months ago (2016-06-28 21:35:35 UTC) #1
dcheng
LGTM from 36000 ft
4 years, 5 months ago (2016-06-28 22:09:04 UTC) #2
danakj
LGTM
4 years, 5 months ago (2016-06-28 22:09:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101263003/1
4 years, 5 months ago (2016-06-28 22:30:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/184845)
4 years, 5 months ago (2016-06-29 00:06:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101263003/1
4 years, 5 months ago (2016-06-29 00:14:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 02:16:13 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 02:17:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5170bf98eb5ad7c6ebbdad175ecd478c3e48ead0
Cr-Commit-Position: refs/heads/master@{#402660}

Powered by Google App Engine
This is Rietveld 408576698