base/trace_event/heap_profiler_allocation_context_tracker.cc - Issue 2101263003: base: Change auto to not deduce raw pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/heap_profiler_allocation_context_tracker.cc

Issue 2101263003: base: Change auto to not deduce raw pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/heap_profiler_allocation_context_tracker.cc

diff --git a/base/trace_event/heap_profiler_allocation_context_tracker.cc b/base/trace_event/heap_profiler_allocation_context_tracker.cc

index fac4a8a7b437b4a8c6792631f252ad8a3e78c8e5..31f311a918e6d5931addb8aecce5ebd2d6420ef1 100644

--- a/base/trace_event/heap_profiler_allocation_context_tracker.cc

+++ b/base/trace_event/heap_profiler_allocation_context_tracker.cc

@@ -168,8 +168,8 @@ AllocationContext AllocationContextTracker::GetContextSnapshot() {

CaptureMode mode = static_cast<CaptureMode>(

subtle::NoBarrier_Load(&capture_mode_));

- auto backtrace = std::begin(ctx.backtrace.frames);

- auto backtrace_end = std::end(ctx.backtrace.frames);

+ auto* backtrace = std::begin(ctx.backtrace.frames);

+ auto* backtrace_end = std::end(ctx.backtrace.frames);

if (!thread_name_) {

// Ignore the string allocation made by GetAndLeakThreadName to avoid