Revert of Change Numeric sourceInfos into sample diagnostics

Revert of Change Numeric sourceInfos into sample diagnostics (patchset #2 id:60001 of https://codereview.chromium.org/2080183004/ )

Reason for revert:
Cause TBMv2 benchmarks failure everywhere.

BUG=623963
Original issue's description:
> Change Numeric sourceInfos into sample diagnostics
> 
> Currently, when metrics add samples to Numerics, they can optionally pass an
> arbitrary POD javascript object to help users find the sample's source
> in a trace. This concept maps directly to the new strongly-typed RelatedEventSet
> diagnostic, or diagnostics more generally, which also provide a system to display
> the data through tr.v.ui.createDiagnosticSpan().
> 
> This CL allows a single un-named Diagnostic object to be associated with each
> sample. It may become necessary in the future to allow entire DiagnosticMaps to be
> associated with each sample, but we haven't seen a need for that yet.
> 
> A future CL will somehow need to associate sample diagnostics with IterationInfos
> so that users can actually click through related events.
> 
> BUG=catapult:#2180
> 
> Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/67bdb1c3d8755c1197598eb8f0a5032992979da5

TBR=eakuefner@chromium.org,benjhayden@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#2180

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/59d08c8ab9f92ac5dfbf2f29b34ac7bb5f953bd8

[nednguyen, 2016-06-28 15:27:52]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2016-06-28 15:27:52]

Created Revert of Change Numeric sourceInfos into sample diagnostics

[commit-bot: I haz the power, 2016-06-28 15:27:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 15:28:05]

Description was changed from

==========
Revert of Change Numeric sourceInfos into sample diagnostics (patchset #2
id:60001 of https://codereview.chromium.org/2080183004/ )

Reason for revert:
Cause TBMv2 benchmarks failure everywhere.

BUG=623963

Original issue's description:
> Change Numeric sourceInfos into sample diagnostics
> 
> Currently, when metrics add samples to Numerics, they can optionally pass an
> arbitrary POD javascript object to help users find the sample's source
> in a trace. This concept maps directly to the new strongly-typed
RelatedEventSet
> diagnostic, or diagnostics more generally, which also provide a system to
display
> the data through tr.v.ui.createDiagnosticSpan().
> 
> This CL allows a single un-named Diagnostic object to be associated with each
> sample. It may become necessary in the future to allow entire DiagnosticMaps
to be
> associated with each sample, but we haven't seen a need for that yet.
> 
> A future CL will somehow need to associate sample diagnostics with
IterationInfos
> so that users can actually click through related events.
> 
> BUG=catapult:#2180
> 
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=eakuefner@chromium.org,benjhayden@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#2180
==========

to

==========
Revert of Change Numeric sourceInfos into sample diagnostics (patchset #2
id:60001 of https://codereview.chromium.org/2080183004/ )

Reason for revert:
Cause TBMv2 benchmarks failure everywhere.

BUG=623963

Original issue's description:
> Change Numeric sourceInfos into sample diagnostics
> 
> Currently, when metrics add samples to Numerics, they can optionally pass an
> arbitrary POD javascript object to help users find the sample's source
> in a trace. This concept maps directly to the new strongly-typed
RelatedEventSet
> diagnostic, or diagnostics more generally, which also provide a system to
display
> the data through tr.v.ui.createDiagnosticSpan().
> 
> This CL allows a single un-named Diagnostic object to be associated with each
> sample. It may become necessary in the future to allow entire DiagnosticMaps
to be
> associated with each sample, but we haven't seen a need for that yet.
> 
> A future CL will somehow need to associate sample diagnostics with
IterationInfos
> so that users can actually click through related events.
> 
> BUG=catapult:#2180
> 
> Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

TBR=eakuefner@chromium.org,benjhayden@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=catapult:#2180

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-28 15:28:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[nduca, 2016-06-28 15:47:59]

do we know what test coverage is missing that let this get through?

[nednguyen, 2016-06-28 17:53:51]

On 2016/06/28 15:47:59, nduca wrote:
> do we know what test coverage is missing that let this get through?

Ben: when you reland this patch, can you make sure that you add a test that
would fail without the fix?