tracing/tracing/metrics/system_health/long_tasks_metric.html - Issue 2101233003: Revert of Change Numeric sourceInfos into sample diagnostics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/metrics/system_health/long_tasks_metric.html

Issue 2101233003: Revert of Change Numeric sourceInfos into sample diagnostics (Closed) Base URL: https://github.com/catapult-project/catapult.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/first_paint_metric.html ('k') | tracing/tracing/metrics/system_health/responsiveness_metric.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/metrics/system_health/long_tasks_metric.html

diff --git a/tracing/tracing/metrics/system_health/long_tasks_metric.html b/tracing/tracing/metrics/system_health/long_tasks_metric.html

index 8bbf186030fea1e837b37f45300b32fe4172141d..1e2fea97a19ff3e9a36cf9f7e620a35a610c57f9 100644

--- a/tracing/tracing/metrics/system_health/long_tasks_metric.html

+++ b/tracing/tracing/metrics/system_health/long_tasks_metric.html

@@ -83,8 +83,7 @@

iterateRendererMainThreads(model, function(thread) {

iterateLongTopLevelTasksOnThreadInRange(

thread, rangeOfInterest, function(task) {

- longTaskNumeric.add(task.duration,

- new tr.v.d.RelatedEventSet([task]));

+ longTaskNumeric.add(task.duration, task.stableId);

});

var options = {description: 'durations of long tasks'};