Added tests for bug detection on locals

Added tests for bug detection on locals

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=eeb9220b781cb8e17766b900a3e7575a4fe4c41a

[tlively, 2016-06-28 01:45:54]

tlively@google.com changed reviewers:
+ kschimpf@google.com, mcgrathr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-06-28 13:46:08]

https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorl...
File tests_lit/asan_tests/errorlocaloffbymany.ll (right):

https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorl...
tests_lit/asan_tests/errorlocaloffbymany.ll:5: ; RUN: llvm-as %s -o - |
pnacl-freeze > %t.pexe && %S/../../pydir/szbuild.py \
This is a very clever way to make a lit test actually run and produce results.

I noticed that these three files are essentially identical except for the
@access() function.  Do you think they can be combined into a single .ll file,
with multiple @access functions and multiple RUN lines?

If you could somehow get access to argc, you could run the executable as "a.out
1" or "a.out 1 2" or "a.out 1 2 3" and then have @_start() use the value of argc
to decide which version of @access() to dispatch.

https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorl...
tests_lit/asan_tests/errorlocaloffbymany.ll:31: 
remove trailing whitespace (i.e. blank line)

[tlively, 2016-06-28 21:11:23]

https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorl...
File tests_lit/asan_tests/errorlocaloffbymany.ll (right):

https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorl...
tests_lit/asan_tests/errorlocaloffbymany.ll:5: ; RUN: llvm-as %s -o - |
pnacl-freeze > %t.pexe && %S/../../pydir/szbuild.py \
On 2016/06/28 13:46:08, stichnot wrote:
> This is a very clever way to make a lit test actually run and produce results.
> 
> I noticed that these three files are essentially identical except for the
> @access() function.  Do you think they can be combined into a single .ll file,
> with multiple @access functions and multiple RUN lines?
> 
> If you could somehow get access to argc, you could run the executable as
"a.out
> 1" or "a.out 1 2" or "a.out 1 2 3" and then have @_start() use the value of
argc
> to decide which version of @access() to dispatch.

Done.

https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorl...
tests_lit/asan_tests/errorlocaloffbymany.ll:31: 
On 2016/06/28 13:46:08, stichnot wrote:
> remove trailing whitespace (i.e. blank line)

Done.

[Jim Stichnoth, 2016-06-28 21:24:57]

lgtm

[tlively, 2016-06-29 05:16:08]

Description was changed from

==========
Added tests for bug detection on locals

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

to

==========
Added tests for bug detection on locals

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[tlively, 2016-06-29 05:16:10]

Committed patchset #3 (id:40001) manually as
eeb9220b781cb8e17766b900a3e7575a4fe4c41a (presubmit successful).