Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2101173002: Added tests for bug detection on locals (Closed)

Created:
4 years, 5 months ago by tlively
Modified:
4 years, 5 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added tests for bug detection on locals BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=eeb9220b781cb8e17766b900a3e7575a4fe4c41a

Patch Set 1 #

Total comments: 4

Patch Set 2 : Moved error tests into a single file #

Patch Set 3 : Fixed test file comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -1 line) Patch
M runtime/szrt_asan.c View 1 chunk +4 lines, -1 line 0 comments Download
A tests_lit/asan_tests/errors.ll View 1 2 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tlively
4 years, 5 months ago (2016-06-28 01:45:54 UTC) #2
Jim Stichnoth
https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorlocaloffbymany.ll File tests_lit/asan_tests/errorlocaloffbymany.ll (right): https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorlocaloffbymany.ll#newcode5 tests_lit/asan_tests/errorlocaloffbymany.ll:5: ; RUN: llvm-as %s -o - | pnacl-freeze > ...
4 years, 5 months ago (2016-06-28 13:46:08 UTC) #3
tlively
https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorlocaloffbymany.ll File tests_lit/asan_tests/errorlocaloffbymany.ll (right): https://codereview.chromium.org/2101173002/diff/1/tests_lit/asan_tests/errorlocaloffbymany.ll#newcode5 tests_lit/asan_tests/errorlocaloffbymany.ll:5: ; RUN: llvm-as %s -o - | pnacl-freeze > ...
4 years, 5 months ago (2016-06-28 21:11:23 UTC) #4
Jim Stichnoth
lgtm
4 years, 5 months ago (2016-06-28 21:24:57 UTC) #5
tlively
4 years, 5 months ago (2016-06-29 05:16:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
eeb9220b781cb8e17766b900a3e7575a4fe4c41a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698