tests_lit/asan_tests/errorlocaloffbymany.ll - Issue 2101173002: Added tests for bug detection on locals

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/asan_tests/errorlocaloffbymany.ll

Issue 2101173002: Added tests for bug detection on locals (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 ; Make sure off-by-many OOB accesses of locals are caught

	2

	3 ; REQUIRES: no_minimal_build

	4

	5 ; RUN: llvm-as %s -o - \| pnacl-freeze > %t.pexe && %S/../../pydir/szbuild.py \
	Jim Stichnoth 2016/06/28 13:46:08 This is a very clever way to make a lit test actua This is a very clever way to make a lit test actually run and produce results. I noticed that these three files are essentially identical except for the @access() function. Do you think they can be combined into a single .ll file, with multiple @access functions and multiple RUN lines? If you could somehow get access to argc, you could run the executable as "a.out 1" or "a.out 1 2" or "a.out 1 2 3" and then have @_start() use the value of argc to decide which version of @access() to dispatch. tlively 2016/06/28 21:11:23 Done. Show quoted text On 2016/06/28 13:46:08, stichnot wrote: > This is a very clever way to make a lit test actually run and produce results. > > I noticed that these three files are essentially identical except for the > @access() function. Do you think they can be combined into a single .ll file, > with multiple @access functions and multiple RUN lines? > > If you could somehow get access to argc, you could run the executable as "a.out > 1" or "a.out 1 2" or "a.out 1 2 3" and then have @_start() use the value of argc > to decide which version of @access() to dispatch. Done.
	6 ; RUN: --fsanitize-address --sz="-allow-externally-defined-symbols" \

	7 ; RUN: %t.pexe -o %t && not --crash %t 2>&1 \| FileCheck \

	8 ; RUN: --check-prefix=CHECK32 %s

	9

	10 declare external void @exit(i32)

	11

	12 ; A global array

	13 @arr = internal constant [12 x i8] zeroinitializer

	14

	15 define i32 @access() {

	16 %arr = alloca i8, i32 12, align 1

	17 %arraddr = ptrtoint i8* %arr to i32

	18 %badaddr = add i32 20, %arraddr

	19 %badptr = inttoptr i32 %badaddr to i32*

	20 %result = load i32, i32* %badptr, align 1

	21 ret i32 %result

	22 }

	23

	24 define void @_start(i32 %__0) {

	25 %result = call i32 @access()

	26 call void @exit(i32 0)

	27 unreachable

	28 }

	29

	30 ; CHECK32: Illegal access of 4 bytes at

	31
	Jim Stichnoth 2016/06/28 13:46:08 remove trailing whitespace (i.e. blank line) remove trailing whitespace (i.e. blank line) tlively 2016/06/28 21:11:23 Done. Show quoted text On 2016/06/28 13:46:08, stichnot wrote: > remove trailing whitespace (i.e. blank line) Done.
OLD	NEW

« no previous file with comments | « runtime/szrt_asan.c ('k') | tests_lit/asan_tests/errorlocaloffbynegative.ll » ('j') | no next file with comments »