third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js - Issue 2101143002: DevTools: Fix a bug where user agent shadow dom elements were inspectable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

Issue 2101143002: DevTools: Fix a bug where user agent shadow dom elements were inspectable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

index 33e2b0dbf7c7f7385f8f4e6382a564c488cf3f1c..7d974cb2759ce76945c96b750823555c905ef45a 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js

@@ -869,7 +869,7 @@ WebInspector.ElementsPanel.prototype = {

_leaveUserAgentShadowDOM: function(node)

{

var userAgentShadowRoot = node.ancestorUserAgentShadowRoot();

- return userAgentShadowRoot ? /** @type {!WebInspector.DOMNode} */ (userAgentShadowRoot.parentNode) : node;

+ return (userAgentShadowRoot && userAgentShadowRoot.parentNode) ? this._leaveUserAgentShadowDOM(userAgentShadowRoot.parentNode) : node;

dgozman 2016/06/28 01:30:29 Let's turn this into a while loop.

/**

« no previous file with comments | « no previous file | no next file » | no next file with comments »