Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2101143002: DevTools: Fix a bug where user agent shadow dom elements were inspectable (Closed)

Created:
4 years, 5 months ago by einbinder
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix a bug where user agent shadow dom elements were inspectable by recursively checking for shadow dom BUG=582317 Committed: https://crrev.com/63dae32710b9465a7a6a906e4be1bc2bc138e651 Cr-Commit-Position: refs/heads/master@{#403359}

Patch Set 1 #

Total comments: 1

Patch Set 2 : No longer recursive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
einbinder
4 years, 5 months ago (2016-06-28 00:55:14 UTC) #2
dgozman
lgtm https://codereview.chromium.org/2101143002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js File third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/2101143002/diff/1/third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js#newcode872 third_party/WebKit/Source/devtools/front_end/elements/ElementsPanel.js:872: return (userAgentShadowRoot && userAgentShadowRoot.parentNode) ? this._leaveUserAgentShadowDOM(userAgentShadowRoot.parentNode) : node; ...
4 years, 5 months ago (2016-06-28 01:30:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2101143002/20001
4 years, 5 months ago (2016-06-30 22:44:08 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-01 00:12:07 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 00:15:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63dae32710b9465a7a6a906e4be1bc2bc138e651
Cr-Commit-Position: refs/heads/master@{#403359}

Powered by Google App Engine
This is Rietveld 408576698