Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2101113002: Fix break in TestExpectations for virtual/pointerevent tests (Closed)

Created:
4 years, 5 months ago by ericrk
Modified:
4 years, 5 months ago
Reviewers:
mustaq, wkorman
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix break in TestExpectations for virtual/pointerevent tests crrev.com/2086283003 added a skip rule for virtual/pointerevent/... This landed at the same time as crrev.com/2098883002 which removed the entire virtual/pointerevent test suite. Somehow these both made it through CQ, leaving TestExpecations in a bad sate. Any future changes to TestExpectations now hit a lint error: LayoutTests/TestExpectations:1201 Path does not exist. virtual/pointerevent/imported/wpt/pointerevents/pointerevent_properties_mouse-manual.html This change removes the offending line (the line above it already achieves the same thing for the non-virtual test, which is now the only one. TBR=wkorman,mustaq Committed: https://chromium.googlesource.com/chromium/src/+/080f7156a8e38040077f1f85083c4d138297332d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/080f7156a8e38040077f1f85083c4d138297332d Cr-Commit-Position: refs/heads/master@{#402341}
4 years, 5 months ago (2016-06-28 00:25:30 UTC) #2
ericrk
Committed patchset #1 (id:1) manually as 080f7156a8e38040077f1f85083c4d138297332d (presubmit successful).
4 years, 5 months ago (2016-06-28 00:26:43 UTC) #4
mustaq
4 years, 5 months ago (2016-06-28 13:37:47 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698