Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Issue 2100873002: Fix up flags to SkGpuBlurUtils::GaussianBlur (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
Brian Osman, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix up flags to SkGpuBlurUtils::GaussianBlur This fixes a bug introduced in: https://codereview.chromium.org/1961953002/ (Reland of Simplify SkGpuBlurUtils::GaussianBlur method) Although the 'canOverwriteSrc' flag is/was being used I still believe we're better off re-adding it after the mask-blur refactoring finishes. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2100873002 Committed: https://skia.googlesource.com/skia/+/8bad3acce52a24fb99d3201a0cefa54eacf9ee57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M include/core/SkMaskFilter.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/core/SkMaskFilter.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
robertphillips
4 years, 5 months ago (2016-06-27 13:50:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100873002/1
4 years, 5 months ago (2016-06-27 15:00:20 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-27 15:26:03 UTC) #9
Brian Osman
lgtm
4 years, 5 months ago (2016-06-27 17:45:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100873002/1
4 years, 5 months ago (2016-06-27 17:47:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on master.client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/10705)
4 years, 5 months ago (2016-06-27 17:49:05 UTC) #14
robertphillips
4 years, 5 months ago (2016-06-27 18:03:00 UTC) #16
bsalomon
lgtm
4 years, 5 months ago (2016-06-27 18:04:40 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2100873002/1
4 years, 5 months ago (2016-06-27 18:10:11 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 18:11:08 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8bad3acce52a24fb99d3201a0cefa54eacf9ee57

Powered by Google App Engine
This is Rietveld 408576698