Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2100833003:
Add role="presentation" to Media Router #search-results element (Closed)
|
Created:
4 years, 5 months ago by takumif Modified:
4 years, 5 months ago Reviewers:
apacible CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd role="presentation" to Media Router #search-results element
To address the ARIA_08 accessibility issue [1], we added
the attribute role="presentation" to certain HTML elements [2].
However, the attribute was removed from one of the elements in
a later commit [3], so this CL adds the attribute back.
This issue surfaced while I was writing a test for the search result
list view [4].
[1] http://crbug/591552
[2] https://codereview.chromium.org/1849283004
[3] https://codereview.chromium.org/1754713005
[4] https://codereview.chromium.org/2096733002
BUG=623260
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/1a7ae6b085e411ec9be7169fce3c5fe9db2b6c76
Cr-Commit-Position: refs/heads/master@{#402266}
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
Description was changed from ========== Add role="presentation" to Media Router \#search-results element To address the ARIA_08 accessibility issue (crbug/591552), we added the attribute role="presentation" to certain HTML elements (https://codereview.chromium.org/1849283004). However, the attribute was removed from one of the elements in a later commit (https://codereview.chromium.org/1754713005), so this CL adds the attribute back. BUG=623260 ========== to ========== Add role="presentation" to Media Router \#search-results element To address the ARIA_08 accessibility issue (crbug/591552), we added the attribute role="presentation" to certain HTML elements (https://codereview.chromium.org/1849283004). However, the attribute was removed from one of the elements in a later commit (https://codereview.chromium.org/1754713005), so this CL adds the attribute back. BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
takumif@chromium.org changed reviewers: + apacible@chromium.org
Here's the one-line fix for the ARIA_08 accessibility bug. Please take a look, thanks!
Thanks! lgtm w/minor comments: - You mentioned offline that you found this while writing tests for another CL. Please link to the CL here for reference, as the test there will cover this issue. - Do you need a \backslash in the title? - Personal preference: When referring to links, I find it cleaner and easier to read if links[1] are mentioned like this[2]. I also do this for crbug updates. [1] link one here [2] link two here
Description was changed from ========== Add role="presentation" to Media Router \#search-results element To address the ARIA_08 accessibility issue (crbug/591552), we added the attribute role="presentation" to certain HTML elements (https://codereview.chromium.org/1849283004). However, the attribute was removed from one of the elements in a later commit (https://codereview.chromium.org/1754713005), so this CL adds the attribute back. BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
On 2016/06/27 18:42:26, apacible wrote: > Thanks! lgtm w/minor comments: > - You mentioned offline that you found this while writing tests for another CL. > Please link to the CL here for reference, as the test there will cover this > issue. > > - Do you need a \backslash in the title? > > - Personal preference: When referring to links, I find it cleaner and easier to > read if links[1] are mentioned like this[2]. I also do this for crbug updates. > > [1] link one here > [2] link two here Thanks for the formatting suggestion! Updated the description accordingly.
Description was changed from ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. This issue surfaced while I was writing a test for the search result list view [4]. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 [4] https://codereview.chromium.org/2096733002 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. This issue surfaced while I was writing a test for the search result list view [4]. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 [4] https://codereview.chromium.org/2096733002 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. This issue surfaced while I was writing a test for the search result list view [4]. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 [4] https://codereview.chromium.org/2096733002 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. This issue surfaced while I was writing a test for the search result list view [4]. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 [4] https://codereview.chromium.org/2096733002 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation ========== to ========== Add role="presentation" to Media Router #search-results element To address the ARIA_08 accessibility issue [1], we added the attribute role="presentation" to certain HTML elements [2]. However, the attribute was removed from one of the elements in a later commit [3], so this CL adds the attribute back. This issue surfaced while I was writing a test for the search result list view [4]. [1] http://crbug/591552 [2] https://codereview.chromium.org/1849283004 [3] https://codereview.chromium.org/1754713005 [4] https://codereview.chromium.org/2096733002 BUG=623260 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/1a7ae6b085e411ec9be7169fce3c5fe9db2b6c76 Cr-Commit-Position: refs/heads/master@{#402266} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/1a7ae6b085e411ec9be7169fce3c5fe9db2b6c76 Cr-Commit-Position: refs/heads/master@{#402266} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
