Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1849283004: [Media Router WebUI] Resolve AX_ARIA_08 failure. (Closed)

Created:
4 years, 8 months ago by apacible
Modified:
4 years, 8 months ago
Reviewers:
mark a. foltz
CC:
arv+watch_chromium.org, chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Resolve AX_ARIA_08 failure. This is caused by role mismatches using the Polymer elements. After some discussion, the recommendation was to manually set the menu roles. BUG=591552 Committed: https://crrev.com/6f3d7c412a3e923c1a4372a40b2e811da1b46023 Cr-Commit-Position: refs/heads/master@{#384784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/media_router/media_router_elements_browsertest.js View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
apacible
PTAL, thanks!
4 years, 8 months ago (2016-04-01 21:31:04 UTC) #3
mark a. foltz
LGTM Is this a Polymer bug? Do you think it should be filed upstream in ...
4 years, 8 months ago (2016-04-01 23:58:46 UTC) #4
apacible
On 2016/04/01 23:58:46, mark a. foltz wrote: > LGTM > > Is this a Polymer ...
4 years, 8 months ago (2016-04-02 02:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849283004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849283004/1
4 years, 8 months ago (2016-04-02 02:25:40 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 02:32:06 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 02:33:28 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6f3d7c412a3e923c1a4372a40b2e811da1b46023
Cr-Commit-Position: refs/heads/master@{#384784}

Powered by Google App Engine
This is Rietveld 408576698