Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 210083002: Specify printing format of touch point co-ordinates. (Closed)

Created:
6 years, 9 months ago by tdresser
Modified:
6 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Specify printing format of touch point co-ordinates. Currently touch point co-ordinates are printed as floating point, with no specified number of decimal places. This leads to inconsistent and hard to read output. This patch prints touch point co-ordinates with two decimal places of accuracy. A follow up patch will re-enable plugins/touch-events-details.html and plugins/transformed-events.html, and update their expectations. BUG=354787 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259570

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/shell/renderer/test_runner/TestPlugin.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
tdresser
dpranke, do you think this is reasonable? Comparing floating point values in layout tests feels ...
6 years, 9 months ago (2014-03-24 14:49:20 UTC) #1
tdresser
On 2014/03/24 14:49:20, tdresser wrote: > dpranke, do you think this is reasonable? > > ...
6 years, 9 months ago (2014-03-24 14:54:03 UTC) #2
Dirk Pranke
looks and sounds reasonable to me. There are a few places where we do look ...
6 years, 9 months ago (2014-03-26 01:02:12 UTC) #3
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 9 months ago (2014-03-26 11:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/210083002/1
6 years, 9 months ago (2014-03-26 11:56:20 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 14:16:22 UTC) #6
Message was sent while issue was closed.
Change committed as 259570

Powered by Google App Engine
This is Rietveld 408576698