Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 210093002: Update layout tests to use floats for touch point locations. (Closed)

Created:
6 years, 9 months ago by tdresser
Modified:
6 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Update layout tests to use floats for touch point locations. plugins/touch-events-details.html and plugins/transformed-events.html started to fail when touch point locations became floating point. This patch fixes that. This depends on https://codereview.chromium.org/210083002/. BUG=354787 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -17 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/plugins/touch-events-details-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/plugins/transformed-events-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
tdresser
PTAL. This is the follow up to https://codereview.chromium.org/210083002/.
6 years, 9 months ago (2014-03-26 15:25:54 UTC) #1
Dirk Pranke
lgtm
6 years, 9 months ago (2014-03-26 19:39:52 UTC) #2
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 9 months ago (2014-03-26 19:41:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/210093002/1
6 years, 9 months ago (2014-03-26 19:41:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 19:52:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 19:52:01 UTC) #6
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 9 months ago (2014-03-26 19:54:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/210093002/1
6 years, 9 months ago (2014-03-26 19:54:34 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 20:29:32 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-26 20:29:33 UTC) #10
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 9 months ago (2014-03-27 12:09:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/210093002/1
6 years, 9 months ago (2014-03-27 12:09:25 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 12:31:41 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-27 12:31:41 UTC) #14
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 9 months ago (2014-03-27 13:25:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/210093002/1
6 years, 9 months ago (2014-03-27 13:25:41 UTC) #16
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 14:02:15 UTC) #17
Message was sent while issue was closed.
Change committed as 170179

Powered by Google App Engine
This is Rietveld 408576698