PageLoadTiming fixes in prep for using base::Optional

PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=623556
Committed: https://crrev.com/4a92b31b73ae1410660625e7b833dde4556217ca
Cr-Commit-Position: refs/heads/master@{#403266}

[Bryan McQuade, 2016-06-27 02:40:15]

Description was changed from

==========
Basic change to show that base::Optional doesn't work with gmock.

BUG=
==========

to

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details.

BUG=
==========

[Bryan McQuade, 2016-06-28 17:19:47]

Description was changed from

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details.

BUG=
==========

to

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=
==========

[Bryan McQuade, 2016-06-30 12:56:32]

Description was changed from

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=
==========

to

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=623556
==========

[Bryan McQuade, 2016-06-30 12:59:11]

bmcquade@chromium.org changed reviewers:
+ shivanisha@chromium.org

[Bryan McQuade, 2016-06-30 12:59:23]

shivanisha, PTAL

[shivanisha, 2016-06-30 19:13:53]

On 2016/06/30 at 12:59:23, bmcquade wrote:
> shivanisha, PTAL

LGTM

[Bryan McQuade, 2016-06-30 19:23:26]

The CQ bit was checked by bmcquade@chromium.org

[commit-bot: I haz the power, 2016-06-30 19:23:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 20:24:21]

Committed patchset #19 (id:360001)

[commit-bot: I haz the power, 2016-06-30 20:24:49]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 20:28:09]

Description was changed from

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=623556
==========

to

==========
PageLoadTiming fixes in prep for using base::Optional

We use PageLoadTiming with gmock in a few places. gmock sometimes passes
objects to functions by value. In these cases, if PageLoadTiming contains
base::Optional members, the code fails to compile on windows due to as
issue with Optional's use of aligned memory.

This changes updates our use of PageLoadTiming with gmock to no longer
use aspects of gmock that pass PageLoadTiming by value.

This factors common code into a new FakePageTimingMetricsIPCSender class,
which provides the functionality we had been using gmock for.

See https://groups.google.com/forum/#!topic/googletestframework/W-Hud3j_c6I
for additional details on why gmock is not compatible with Optional.

BUG=623556

Committed: https://crrev.com/4a92b31b73ae1410660625e7b833dde4556217ca
Cr-Commit-Position: refs/heads/master@{#403266}
==========

[commit-bot: I haz the power, 2016-06-30 20:28:10]

Patchset 19 (id:??) landed as
https://crrev.com/4a92b31b73ae1410660625e7b833dde4556217ca
Cr-Commit-Position: refs/heads/master@{#403266}